For some unknown reason at Steven Rostedt added in disabling of the SPE
instruction generation for e500 based PPC cores in commit
6ec562328fda585be2d7f472cfac99d3b44d362a.
We are removing it because:
1. It generates e500 kernels that don't work
2. its not the correct set of flags to do this
3. we handle this in the arch/powerpc/Makefile already
4. its unknown in talking to Steven why he did this
Signed-off-by: Kumar Gala <[email protected]>
---
kernel/Makefile | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/kernel/Makefile b/kernel/Makefile
index 9a3ec66..19fad00 100644
--- a/kernel/Makefile
+++ b/kernel/Makefile
@@ -11,8 +11,6 @@ obj-y = sched.o fork.o exec_domain.o panic.o printk.o \
hrtimer.o rwsem.o nsproxy.o srcu.o semaphore.o \
notifier.o ksysfs.o pm_qos_params.o sched_clock.o
-CFLAGS_REMOVE_sched.o = -mno-spe
-
ifdef CONFIG_FUNCTION_TRACER
# Do not trace debug files and internal ftrace files
CFLAGS_REMOVE_lockdep.o = -pg
@@ -21,7 +19,7 @@ CFLAGS_REMOVE_mutex-debug.o = -pg
CFLAGS_REMOVE_rtmutex-debug.o = -pg
CFLAGS_REMOVE_cgroup-debug.o = -pg
CFLAGS_REMOVE_sched_clock.o = -pg
-CFLAGS_REMOVE_sched.o = -mno-spe -pg
+CFLAGS_REMOVE_sched.o = -pg
endif
obj-$(CONFIG_FREEZER) += freezer.o
--
1.5.6.5
Kumar Gala wrote:
> For some unknown reason at Steven Rostedt added in disabling of the SPE
> instruction generation for e500 based PPC cores in commit
> 6ec562328fda585be2d7f472cfac99d3b44d362a.
>
The unknown reason was that my PPC64 failed to compile without it ;-) It
was unknown because I forgot to mention that in the change log (my bad).
On Monday, I'll apply this patch and make sure that my PPC64 still compiles.
-- Steve
> We are removing it because:
>
> 1. It generates e500 kernels that don't work
> 2. its not the correct set of flags to do this
> 3. we handle this in the arch/powerpc/Makefile already
> 4. its unknown in talking to Steven why he did this
>
> Signed-off-by: Kumar Gala <[email protected]>
> ---
> kernel/Makefile | 4 +---
> 1 files changed, 1 insertions(+), 3 deletions(-)
>
> diff --git a/kernel/Makefile b/kernel/Makefile
> index 9a3ec66..19fad00 100644
> --- a/kernel/Makefile
> +++ b/kernel/Makefile
> @@ -11,8 +11,6 @@ obj-y = sched.o fork.o exec_domain.o panic.o printk.o \
> hrtimer.o rwsem.o nsproxy.o srcu.o semaphore.o \
> notifier.o ksysfs.o pm_qos_params.o sched_clock.o
>
> -CFLAGS_REMOVE_sched.o = -mno-spe
> -
> ifdef CONFIG_FUNCTION_TRACER
> # Do not trace debug files and internal ftrace files
> CFLAGS_REMOVE_lockdep.o = -pg
> @@ -21,7 +19,7 @@ CFLAGS_REMOVE_mutex-debug.o = -pg
> CFLAGS_REMOVE_rtmutex-debug.o = -pg
> CFLAGS_REMOVE_cgroup-debug.o = -pg
> CFLAGS_REMOVE_sched_clock.o = -pg
> -CFLAGS_REMOVE_sched.o = -mno-spe -pg
> +CFLAGS_REMOVE_sched.o = -pg
> endif
>
> obj-$(CONFIG_FREEZER) += freezer.o
>
On Nov 15, 2008, at 12:10 PM, Steven Rostedt wrote:
> Kumar Gala wrote:
>> For some unknown reason at Steven Rostedt added in disabling of the
>> SPE
>> instruction generation for e500 based PPC cores in commit
>> 6ec562328fda585be2d7f472cfac99d3b44d362a.
>>
>
> The unknown reason was that my PPC64 failed to compile without
> it ;-) It was unknown because I forgot to mention that in the change
> log (my bad).
>
> On Monday, I'll apply this patch and make sure that my PPC64 still
> compiles.
>
> -- Steve
Thanks, if you can Ack the patch today if it works for you that would
be great.
- k
>
>
>> We are removing it because:
>>
>> 1. It generates e500 kernels that don't work
>> 2. its not the correct set of flags to do this
>> 3. we handle this in the arch/powerpc/Makefile already
>> 4. its unknown in talking to Steven why he did this
>>
>> Signed-off-by: Kumar Gala <[email protected]>
>> ---
>> kernel/Makefile | 4 +---
>> 1 files changed, 1 insertions(+), 3 deletions(-)
>
On Nov 15, 2008, at 12:10 PM, Steven Rostedt wrote:
> Kumar Gala wrote:
>> For some unknown reason at Steven Rostedt added in disabling of the
>> SPE
>> instruction generation for e500 based PPC cores in commit
>> 6ec562328fda585be2d7f472cfac99d3b44d362a.
>>
>
> The unknown reason was that my PPC64 failed to compile without
> it ;-) It was unknown because I forgot to mention that in the change
> log (my bad).
Are you sure you were building a ppc64 kernel? This makes no sense in
that the -mno-spe flag should not be relevant at all to such a kernel
build. (No ppc64 chip has SPE support and thus the compiler doesnt
support generation of the instructions in that mode).
Were you building some ppc32 targeted kernel?
- k
Kumar Gala wrote:
> For some unknown reason at Steven Rostedt added in disabling of the SPE
> instruction generation for e500 based PPC cores in commit
> 6ec562328fda585be2d7f472cfac99d3b44d362a.
>
> We are removing it because:
>
> 1. It generates e500 kernels that don't work
> 2. its not the correct set of flags to do this
> 3. we handle this in the arch/powerpc/Makefile already
> 4. its unknown in talking to Steven why he did this
>
>
I just tested this change on both my PPC64 and my 32bit Powerbook.
Tested-and-Acked-by: Steven Rostedt <[email protected]>
-- Steve
> Signed-off-by: Kumar Gala <[email protected]>
> ---
> kernel/Makefile | 4 +---
> 1 files changed, 1 insertions(+), 3 deletions(-)
>
> diff --git a/kernel/Makefile b/kernel/Makefile
> index 9a3ec66..19fad00 100644
> --- a/kernel/Makefile
> +++ b/kernel/Makefile
> @@ -11,8 +11,6 @@ obj-y = sched.o fork.o exec_domain.o panic.o printk.o \
> hrtimer.o rwsem.o nsproxy.o srcu.o semaphore.o \
> notifier.o ksysfs.o pm_qos_params.o sched_clock.o
>
> -CFLAGS_REMOVE_sched.o = -mno-spe
> -
> ifdef CONFIG_FUNCTION_TRACER
> # Do not trace debug files and internal ftrace files
> CFLAGS_REMOVE_lockdep.o = -pg
> @@ -21,7 +19,7 @@ CFLAGS_REMOVE_mutex-debug.o = -pg
> CFLAGS_REMOVE_rtmutex-debug.o = -pg
> CFLAGS_REMOVE_cgroup-debug.o = -pg
> CFLAGS_REMOVE_sched_clock.o = -pg
> -CFLAGS_REMOVE_sched.o = -mno-spe -pg
> +CFLAGS_REMOVE_sched.o = -pg
> endif
>
> obj-$(CONFIG_FREEZER) += freezer.o
>