2021-05-06 15:31:06

by Mauro Carvalho Chehab

Subject: [PATCH v5 13/25] media: venus: core: use pm_runtime_resume_and_get()

Commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter")
added pm_runtime_resume_and_get() in order to automatically handle
dev->power.usage_count decrement on errors.

Use the new API, in order to cleanup the error check logic.

Signed-off-by: Mauro Carvalho Chehab <[email protected]>
---
drivers/media/platform/qcom/venus/pm_helpers.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/media/platform/qcom/venus/pm_helpers.c b/drivers/media/platform/qcom/venus/pm_helpers.c
index c7e1ebec47ee..d0fddf5e9a69 100644
--- a/drivers/media/platform/qcom/venus/pm_helpers.c
+++ b/drivers/media/platform/qcom/venus/pm_helpers.c
@@ -990,9 +990,8 @@ static int core_power_v4(struct venus_core *core, int on)

if (on == POWER_ON) {
if (pmctrl) {
- ret = pm_runtime_get_sync(pmctrl);
+ ret = pm_runtime_resume_and_get(pmctrl);
if (ret < 0) {
- pm_runtime_put_noidle(pmctrl);
return ret;
}
}
--
2.30.2

2021-05-10 14:21:39

by Stanimir Varbanov

Subject: Re: [PATCH v5 13/25] media: venus: core: use pm_runtime_resume_and_get()

On 5/6/21 6:25 PM, Mauro Carvalho Chehab wrote:
> Commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter")
> added pm_runtime_resume_and_get() in order to automatically handle
> dev->power.usage_count decrement on errors.
>
> Use the new API, in order to cleanup the error check logic.
>
> Signed-off-by: Mauro Carvalho Chehab <[email protected]>
> ---
> drivers/media/platform/qcom/venus/pm_helpers.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)

Tested-by: Stanimir Varbanov <[email protected]>
Acked-by: Stanimir Varbanov <[email protected]>

>
> diff --git a/drivers/media/platform/qcom/venus/pm_helpers.c b/drivers/media/platform/qcom/venus/pm_helpers.c
> index c7e1ebec47ee..d0fddf5e9a69 100644
> --- a/drivers/media/platform/qcom/venus/pm_helpers.c
> +++ b/drivers/media/platform/qcom/venus/pm_helpers.c
> @@ -990,9 +990,8 @@ static int core_power_v4(struct venus_core *core, int on)
>
> if (on == POWER_ON) {
> if (pmctrl) {
> - ret = pm_runtime_get_sync(pmctrl);
> + ret = pm_runtime_resume_and_get(pmctrl);
> if (ret < 0) {
> - pm_runtime_put_noidle(pmctrl);
> return ret;
> }
> }
>

--
regards,
Stan

2021-05-18 19:24:02

by Stanimir Varbanov

Subject: Re: [PATCH v5 13/25] media: venus: core: use pm_runtime_resume_and_get()

Hi Mauro,

On 5/10/21 4:54 PM, Stanimir Varbanov wrote:
>
>
> On 5/6/21 6:25 PM, Mauro Carvalho Chehab wrote:
>> Commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter")
>> added pm_runtime_resume_and_get() in order to automatically handle
>> dev->power.usage_count decrement on errors.
>>
>> Use the new API, in order to cleanup the error check logic.
>>
>> Signed-off-by: Mauro Carvalho Chehab <[email protected]>
>> ---
>> drivers/media/platform/qcom/venus/pm_helpers.c | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> Tested-by: Stanimir Varbanov <[email protected]>
> Acked-by: Stanimir Varbanov <[email protected]>
>

What is the plan for these venus patches. Do I need to take them through
my Venus pull request for v5.14 or you will take them directly?

>>
>> diff --git a/drivers/media/platform/qcom/venus/pm_helpers.c b/drivers/media/platform/qcom/venus/pm_helpers.c
>> index c7e1ebec47ee..d0fddf5e9a69 100644
>> --- a/drivers/media/platform/qcom/venus/pm_helpers.c
>> +++ b/drivers/media/platform/qcom/venus/pm_helpers.c
>> @@ -990,9 +990,8 @@ static int core_power_v4(struct venus_core *core, int on)
>>
>> if (on == POWER_ON) {
>> if (pmctrl) {
>> - ret = pm_runtime_get_sync(pmctrl);
>> + ret = pm_runtime_resume_and_get(pmctrl);
>> if (ret < 0) {
>> - pm_runtime_put_noidle(pmctrl);
>> return ret;
>> }
>> }
>>
>

--
regards,
Stan

2021-05-19 18:21:53

by Stanimir Varbanov

Subject: Re: [PATCH v5 13/25] media: venus: core: use pm_runtime_resume_and_get()

Hi Mauro,

On 5/18/21 6:20 PM, Mauro Carvalho Chehab wrote:
> Em Mon, 17 May 2021 18:26:14 +0300
> Stanimir Varbanov <[email protected]> escreveu:
>
>> Hi Mauro,
>>
>> On 5/10/21 4:54 PM, Stanimir Varbanov wrote:
>>>
>>>
>>> On 5/6/21 6:25 PM, Mauro Carvalho Chehab wrote:
>>>> Commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter")
>>>> added pm_runtime_resume_and_get() in order to automatically handle
>>>> dev->power.usage_count decrement on errors.
>>>>
>>>> Use the new API, in order to cleanup the error check logic.
>>>>
>>>> Signed-off-by: Mauro Carvalho Chehab <[email protected]>
>>>> ---
>>>> drivers/media/platform/qcom/venus/pm_helpers.c | 3 +--
>>>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>>
>>> Tested-by: Stanimir Varbanov <[email protected]>
>>> Acked-by: Stanimir Varbanov <[email protected]>
>>>
>>
>> What is the plan for these venus patches. Do I need to take them through
>> my Venus pull request for v5.14 or you will take them directly?
>
> Whatever works best for you. In principle, I should apply them on my
> tree probably tomorrow, if ok for you.
>

It is perfectly fine, please apply them. Thank you!

--
regards,
Stan

2021-05-19 18:22:42

by Mauro Carvalho Chehab

Subject: Re: [PATCH v5 13/25] media: venus: core: use pm_runtime_resume_and_get()

Em Mon, 17 May 2021 18:26:14 +0300
Stanimir Varbanov <[email protected]> escreveu:

> Hi Mauro,
>
> On 5/10/21 4:54 PM, Stanimir Varbanov wrote:
> >
> >
> > On 5/6/21 6:25 PM, Mauro Carvalho Chehab wrote:
> >> Commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter")
> >> added pm_runtime_resume_and_get() in order to automatically handle
> >> dev->power.usage_count decrement on errors.
> >>
> >> Use the new API, in order to cleanup the error check logic.
> >>
> >> Signed-off-by: Mauro Carvalho Chehab <[email protected]>
> >> ---
> >> drivers/media/platform/qcom/venus/pm_helpers.c | 3 +--
> >> 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > Tested-by: Stanimir Varbanov <[email protected]>
> > Acked-by: Stanimir Varbanov <[email protected]>
> >
>
> What is the plan for these venus patches. Do I need to take them through
> my Venus pull request for v5.14 or you will take them directly?

Whatever works best for you. In principle, I should apply them on my
tree probably tomorrow, if ok for you.

Regards,
Mauro

>
> >>
> >> diff --git a/drivers/media/platform/qcom/venus/pm_helpers.c b/drivers/media/platform/qcom/venus/pm_helpers.c
> >> index c7e1ebec47ee..d0fddf5e9a69 100644
> >> --- a/drivers/media/platform/qcom/venus/pm_helpers.c
> >> +++ b/drivers/media/platform/qcom/venus/pm_helpers.c
> >> @@ -990,9 +990,8 @@ static int core_power_v4(struct venus_core *core, int on)
> >>
> >> if (on == POWER_ON) {
> >> if (pmctrl) {
> >> - ret = pm_runtime_get_sync(pmctrl);
> >> + ret = pm_runtime_resume_and_get(pmctrl);
> >> if (ret < 0) {
> >> - pm_runtime_put_noidle(pmctrl);
> >> return ret;
> >> }
> >> }
> >>
> >
>



Thanks,
Mauro