2008-11-28 19:44:18

by Hannes Eder

Subject: [PATCH] rtc-ds1511: fix sparse warning

Fix this sparse warning:

drivers/rtc/rtc-ds1511.c:634:2: warning: returning void-valued expression

Signed-off-by: Hannes Eder <[email protected]>
---
drivers/rtc/rtc-ds1511.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/rtc/rtc-ds1511.c b/drivers/rtc/rtc-ds1511.c
index 25caada..062a1d1 100644
--- a/drivers/rtc/rtc-ds1511.c
+++ b/drivers/rtc/rtc-ds1511.c
@@ -631,7 +631,7 @@ ds1511_rtc_init(void)
static void __exit
ds1511_rtc_exit(void)
{
- return platform_driver_unregister(&ds1511_rtc_driver);
+ platform_driver_unregister(&ds1511_rtc_driver);
}

module_init(ds1511_rtc_init);
--
1.5.6.3

2008-11-30 00:40:24

by Alessandro Zummo

Subject: Re: [PATCH] rtc-ds1511: fix sparse warning

On Fri, 28 Nov 2008 17:01:35 +0100
Hannes Eder <[email protected]> wrote:

> Fix this sparse warning:
>
> drivers/rtc/rtc-ds1511.c:634:2: warning: returning void-valued expression
>
> Signed-off-by: Hannes Eder <[email protected]>


Acked-by: Alessandro Zummo <[email protected]>

--

Best regards,

Alessandro Zummo,
Tower Technologies - Torino, Italy

http://www.towertech.it

2008-11-30 13:08:27

by Jiri Kosina

Subject: Re: [PATCH] rtc-ds1511: fix sparse warning

On Sun, 30 Nov 2008, Alessandro Zummo wrote:

> > Fix this sparse warning:
> >
> > drivers/rtc/rtc-ds1511.c:634:2: warning: returning void-valued expression
> >
> > Signed-off-by: Hannes Eder <[email protected]>
> Acked-by: Alessandro Zummo <[email protected]>

Applied to trivial patches tree. If anyone has already merged this through
another subsystem tree, please let me know.

Thanks,

--
Jiri Kosina
SUSE Labs