2008-11-28 19:48:53

by Hannes Eder

Subject: [PATCH] KVM: VMX: fix sparse warning

Impact: make global function static

arch/x86/kvm/vmx.c:134:3: warning: symbol 'vmx_capability' was not declared. Should it be static?

Signed-off-by: Hannes Eder <[email protected]>
---
arch/x86/kvm/vmx.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
index 7ea4855..e446f23 100644
--- a/arch/x86/kvm/vmx.c
+++ b/arch/x86/kvm/vmx.c
@@ -128,7 +128,7 @@ static struct vmcs_config {
u32 vmentry_ctrl;
} vmcs_config;

-struct vmx_capability {
+static struct vmx_capability {
u32 ept;
u32 vpid;
} vmx_capability;
--
1.5.6.3

2008-11-30 10:16:20

by Avi Kivity

Subject: Re: [PATCH] KVM: VMX: fix sparse warning

Hannes Eder wrote:
> Impact: make global function static
>
> arch/x86/kvm/vmx.c:134:3: warning: symbol 'vmx_capability' was not declared. Should it be static?
>

Applied, thanks.

--
error compiling committee.c: too many arguments to function