2008-11-28 20:09:48

by Hannes Eder

Subject: [PATCH] rtc-stk17ta8: fix sparse warning

Fix this sparse warning:

drivers/rtc/rtc-stk17ta8.c:403:2: warning: returning void-valued expression

Signed-off-by: Hannes Eder <[email protected]>
---
drivers/rtc/rtc-stk17ta8.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/rtc/rtc-stk17ta8.c b/drivers/rtc/rtc-stk17ta8.c
index f4cd46e..549990f 100644
--- a/drivers/rtc/rtc-stk17ta8.c
+++ b/drivers/rtc/rtc-stk17ta8.c
@@ -400,7 +400,7 @@ static __init int stk17ta8_init(void)

static __exit void stk17ta8_exit(void)
{
- return platform_driver_unregister(&stk17ta8_rtc_driver);
+ platform_driver_unregister(&stk17ta8_rtc_driver);
}

module_init(stk17ta8_init);
--
1.5.6.3

2008-11-30 00:39:56

by Alessandro Zummo

Subject: Re: [PATCH] rtc-stk17ta8: fix sparse warning

On Fri, 28 Nov 2008 17:11:47 +0100
Hannes Eder <[email protected]> wrote:

> Fix this sparse warning:
>
> drivers/rtc/rtc-stk17ta8.c:403:2: warning: returning void-valued expression
>
> Signed-off-by: Hannes Eder <[email protected]>

Acked-by: Alessandro Zummo <[email protected]>

--

Best regards,

Alessandro Zummo,
Tower Technologies - Torino, Italy

http://www.towertech.it

2008-11-30 13:09:20

by Jiri Kosina

Subject: Re: [PATCH] rtc-stk17ta8: fix sparse warning

On Sun, 30 Nov 2008, Alessandro Zummo wrote:

> > Fix this sparse warning:
> >
> > drivers/rtc/rtc-stk17ta8.c:403:2: warning: returning void-valued expression
> >
> > Signed-off-by: Hannes Eder <[email protected]>
> Acked-by: Alessandro Zummo <[email protected]>

Thanks. The same as for rtc-ds1511 patch -- I have queued it in trivial
tree, if anyone has taken it through another tree, please let me know.

--
Jiri Kosina
SUSE Labs