2008-11-28 19:49:22

by Hannes Eder

Subject: [PATCH] KVM: fix sparse warning

Impact: make global function static

virt/kvm/kvm_main.c:85:6: warning: symbol 'kvm_rebooting' was not declared. Should it be static?

Signed-off-by: Hannes Eder <[email protected]>
---
virt/kvm/kvm_main.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
index 54d25e6..8dab7ce 100644
--- a/virt/kvm/kvm_main.c
+++ b/virt/kvm/kvm_main.c
@@ -82,7 +82,7 @@ struct dentry *kvm_debugfs_dir;
static long kvm_vcpu_ioctl(struct file *file, unsigned int ioctl,
unsigned long arg);

-bool kvm_rebooting;
+static bool kvm_rebooting;

#ifdef KVM_CAP_DEVICE_ASSIGNMENT

--
1.5.6.3

2008-11-30 10:18:22

by Avi Kivity

Subject: Re: [PATCH] KVM: fix sparse warning

Hannes Eder wrote:
> Impact: make global function static
>
> virt/kvm/kvm_main.c:85:6: warning: symbol 'kvm_rebooting' was not declared. Should it be static?
>

Applied, thanks.

--
error compiling committee.c: too many arguments to function