2008-12-25 14:34:42

by Julia Lawall

Subject: [PATCH 4/7] drivers/media/dvb/firesat: Use DEFINE_SPINLOCK

From: Julia Lawall <[email protected]>

SPIN_LOCK_UNLOCKED is deprecated. The following makes the change suggested
in Documentation/spinlocks.txt

The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@@
declarer name DEFINE_SPINLOCK;
identifier xxx_lock;
@@

- spinlock_t xxx_lock = SPIN_LOCK_UNLOCKED;
+ DEFINE_SPINLOCK(xxx_lock);
// </smpl>

Signed-off-by: Julia Lawall <[email protected]>

---
diff -u -p a/drivers/media/dvb/firesat/firesat_1394.c b/drivers/media/dvb/firesat/firesat_1394.c
--- a/drivers/media/dvb/firesat/firesat_1394.c
+++ b/drivers/media/dvb/firesat/firesat_1394.c
@@ -94,7 +94,7 @@ MODULE_DEVICE_TABLE(ieee1394, firesat_id

/* list of all firesat devices */
LIST_HEAD(firesat_list);
-spinlock_t firesat_list_lock = SPIN_LOCK_UNLOCKED;
+DEFINE_SPINLOCK(firesat_list_lock);

static void fcp_request(struct hpsb_host *host,
int nodeid,

2008-12-25 15:32:18

by Stefan Richter

Subject: Re: [PATCH 4/7] drivers/media/dvb/firesat: Use DEFINE_SPINLOCK

Julia Lawall wrote:
> SPIN_LOCK_UNLOCKED is deprecated. The following makes the change suggested
> in Documentation/spinlocks.txt

Committed to linux1394-2.6.git. Thanks,
--
Stefan Richter
-=====-==--- ==-- ==--=
http://arcgraph.de/sr/