2009-01-08 14:21:01

by Eugene Teo

[permalink] [raw]
Subject: Re: [PATCH] IB: check for memory allocation failure [v2]

On Thu, Jan 8, 2009 at 10:05 PM, Niels de Vos
<[email protected]> wrote:
> Hi Eugene,
>
> please see below.

Thanks for reviewing. Here's an updated patch:

Fix error-path NULL deref in c2_register_device().

Signed-off-by: Eugene Teo <[email protected]>
---
drivers/infiniband/hw/amso1100/c2_provider.c | 17 ++++++++++++-----
1 file changed, 12 insertions(+), 5 deletions(-)


Attachments:
(No filename) (396.00 B)
patch (1.61 kB)
Download all attachments

2009-01-08 15:36:55

by Niels de Vos

[permalink] [raw]
Subject: Re: [PATCH] IB: check for memory allocation failure [v2]

Eugene Teo wrote:
> On Thu, Jan 8, 2009 at 10:05 PM, Niels de Vos
> <[email protected]> wrote:
>> Hi Eugene,
>>
>> please see below.
>
> Thanks for reviewing. Here's an updated patch:
>
> Fix error-path NULL deref in c2_register_device().
>
> Signed-off-by: Eugene Teo <[email protected]>

(note: your patch was attached, not inlined...)

There is also an additional kfree() at the end of the patch. It wasn't
included in the first version you sent. Looks correct now imho.

Reviewed-by: Niels de Vos <[email protected]>


> ---
> drivers/infiniband/hw/amso1100/c2_provider.c | 17 ++++++++++++-----
> 1 file changed, 12 insertions(+), 5 deletions(-)



Attachments:
signature.asc (189.00 B)
OpenPGP digital signature