From: Claudiu Beznea <[email protected]>
The rzg2l_wdt watchdog driver cannot work w/o CONFIG_PM=y (e.g. the
clocks are enabled though pm_runtime_* specific APIs). To avoid building
a driver that doesn't work make explicit the dependency on CONFIG_PM.
Suggested-by: Guenter Roeck <[email protected]>
Signed-off-by: Claudiu Beznea <[email protected]>
---
Changes in v6:
- update patch description
- fixed the dependency on COMPILE_TEST previously introduced
Changes in v5:
- updated patch description
- added on a new line the dependency on PM and COMPILE_TEST
Changes in v4:
- s/ARCH_RENESAS/ARCH_RZG2L || ARCH_R9A09G011 due to patch 1/9
Changes in v3:
- make driver depend on PM; with that the "unmet direct dependency"
Reported-by: kernel test robot <[email protected]>
was also fixed
- adapt commit message
Changes in v2:
- this patch is new
drivers/watchdog/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
index f6cb63a0d889..8bd87880ca3b 100644
--- a/drivers/watchdog/Kconfig
+++ b/drivers/watchdog/Kconfig
@@ -911,6 +911,7 @@ config RENESAS_RZN1WDT
config RENESAS_RZG2LWDT
tristate "Renesas RZ/G2L WDT Watchdog"
depends on ARCH_RZG2L || ARCH_R9A09G011 || COMPILE_TEST
+ depends on PM
select WATCHDOG_CORE
help
This driver adds watchdog support for the integrated watchdogs in the
--
2.39.2
Hi Claudiu,
On Thu, Feb 8, 2024 at 1:26 PM Claudiu <[email protected]> wrote:
> From: Claudiu Beznea <[email protected]>
>
> The rzg2l_wdt watchdog driver cannot work w/o CONFIG_PM=y (e.g. the
> clocks are enabled though pm_runtime_* specific APIs). To avoid building
> a driver that doesn't work make explicit the dependency on CONFIG_PM.
>
> Suggested-by: Guenter Roeck <[email protected]>
> Signed-off-by: Claudiu Beznea <[email protected]>
> ---
>
> Changes in v6:
> - update patch description
> - fixed the dependency on COMPILE_TEST previously introduced
Thanks for the update!
> --- a/drivers/watchdog/Kconfig
> +++ b/drivers/watchdog/Kconfig
> @@ -911,6 +911,7 @@ config RENESAS_RZN1WDT
> config RENESAS_RZG2LWDT
> tristate "Renesas RZ/G2L WDT Watchdog"
> depends on ARCH_RZG2L || ARCH_R9A09G011 || COMPILE_TEST
> + depends on PM
depends on PM || COMPILE_TEST
> select WATCHDOG_CORE
> help
> This driver adds watchdog support for the integrated watchdogs in the
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68korg
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Hi, Geert,
On 08.02.2024 14:53, Geert Uytterhoeven wrote:
> Hi Claudiu,
>
> On Thu, Feb 8, 2024 at 1:26 PM Claudiu <[email protected]> wrote:
>> From: Claudiu Beznea <[email protected]>
>>
>> The rzg2l_wdt watchdog driver cannot work w/o CONFIG_PM=y (e.g. the
>> clocks are enabled though pm_runtime_* specific APIs). To avoid building
>> a driver that doesn't work make explicit the dependency on CONFIG_PM.
>>
>> Suggested-by: Guenter Roeck <[email protected]>
>> Signed-off-by: Claudiu Beznea <[email protected]>
>> ---
>>
>> Changes in v6:
>> - update patch description
>> - fixed the dependency on COMPILE_TEST previously introduced
>
> Thanks for the update!
>
>> --- a/drivers/watchdog/Kconfig
>> +++ b/drivers/watchdog/Kconfig
>> @@ -911,6 +911,7 @@ config RENESAS_RZN1WDT
>> config RENESAS_RZG2LWDT
>> tristate "Renesas RZ/G2L WDT Watchdog"
>> depends on ARCH_RZG2L || ARCH_R9A09G011 || COMPILE_TEST
>> + depends on PM
>
> depends on PM || COMPILE_TEST
Isn't "depends on PM" enough? As of [1] ("If multiple dependencies are
defined, they are connected with '&&'") the above:
depends on ARCH_RZG2L || ARCH_R9A09G011 || COMPILE_TEST
depends on PM
are translated into:
depends on (ARCH_RZG2L || ARCH_R9A09G011 || COMPILE_TEST) && PM
Please let me know if I'm wrong.
Thank you,
Claudiu Beznea
[1] https://www.kernel.org/doc/html/next/kbuild/kconfig-language.html
>
>> select WATCHDOG_CORE
>> help
>> This driver adds watchdog support for the integrated watchdogs in the
>
> Gr{oetje,eeting}s,
>
> Geert
>
Hi Claudiu,
On Fri, Feb 9, 2024 at 1:25 PM claudiu beznea <claudiu.beznea@tuxondev> wrote:
> On 08.02.2024 14:53, Geert Uytterhoeven wrote:
> > On Thu, Feb 8, 2024 at 1:26 PM Claudiu <[email protected]> wrote:
> >> From: Claudiu Beznea <[email protected]>
> >>
> >> The rzg2l_wdt watchdog driver cannot work w/o CONFIG_PM=y (e.g. the
> >> clocks are enabled though pm_runtime_* specific APIs). To avoid building
> >> a driver that doesn't work make explicit the dependency on CONFIG_PM.
> >>
> >> Suggested-by: Guenter Roeck <[email protected]>
> >> Signed-off-by: Claudiu Beznea <[email protected]>
> >> ---
> >>
> >> Changes in v6:
> >> - update patch description
> >> - fixed the dependency on COMPILE_TEST previously introduced
> >
> > Thanks for the update!
> >
> >> --- a/drivers/watchdog/Kconfig
> >> +++ b/drivers/watchdog/Kconfig
> >> @@ -911,6 +911,7 @@ config RENESAS_RZN1WDT
> >> config RENESAS_RZG2LWDT
> >> tristate "Renesas RZ/G2L WDT Watchdog"
> >> depends on ARCH_RZG2L || ARCH_R9A09G011 || COMPILE_TEST
> >> + depends on PM
> >
> > depends on PM || COMPILE_TEST
>
> Isn't "depends on PM" enough? As of [1] ("If multiple dependencies are
> defined, they are connected with '&&'") the above:
>
> depends on ARCH_RZG2L || ARCH_R9A09G011 || COMPILE_TEST
> depends on PM
>
> are translated into:
> depends on (ARCH_RZG2L || ARCH_R9A09G011 || COMPILE_TEST) && PM
>
> Please let me know if I'm wrong.
That is correct. But you still can compile-test this driver when
compiling for a different platform, and CONFIG_PM is disabled.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68korg
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Hi, Geert,
On 14.02.2024 17:26, Geert Uytterhoeven wrote:
> Hi Claudiu,
>
> On Fri, Feb 9, 2024 at 1:25 PM claudiu beznea <[email protected]> wrote:
>> On 08.02.2024 14:53, Geert Uytterhoeven wrote:
>>> On Thu, Feb 8, 2024 at 1:26 PM Claudiu <[email protected]> wrote:
>>>> From: Claudiu Beznea <[email protected]>
>>>>
>>>> The rzg2l_wdt watchdog driver cannot work w/o CONFIG_PM=y (e.g. the
>>>> clocks are enabled though pm_runtime_* specific APIs). To avoid building
>>>> a driver that doesn't work make explicit the dependency on CONFIG_PM.
>>>>
>>>> Suggested-by: Guenter Roeck <[email protected]>
>>>> Signed-off-by: Claudiu Beznea <[email protected]>
>>>> ---
>>>>
>>>> Changes in v6:
>>>> - update patch description
>>>> - fixed the dependency on COMPILE_TEST previously introduced
>>>
>>> Thanks for the update!
>>>
>>>> --- a/drivers/watchdog/Kconfig
>>>> +++ b/drivers/watchdog/Kconfig
>>>> @@ -911,6 +911,7 @@ config RENESAS_RZN1WDT
>>>> config RENESAS_RZG2LWDT
>>>> tristate "Renesas RZ/G2L WDT Watchdog"
>>>> depends on ARCH_RZG2L || ARCH_R9A09G011 || COMPILE_TEST
>>>> + depends on PM
>>>
>>> depends on PM || COMPILE_TEST
>>
>> Isn't "depends on PM" enough? As of [1] ("If multiple dependencies are
>> defined, they are connected with '&&'") the above:
>>
>> depends on ARCH_RZG2L || ARCH_R9A09G011 || COMPILE_TEST
>> depends on PM
>>
>> are translated into:
>> depends on (ARCH_RZG2L || ARCH_R9A09G011 || COMPILE_TEST) && PM
>>
>> Please let me know if I'm wrong.
>
> That is correct. But you still can compile-test this driver when
> compiling for a different platform, and CONFIG_PM is disabled.
Ok, I see, thank you!
>
> Gr{oetje,eeting}s,
>
> Geert
>