2009-03-19 02:32:18

by Frank Rowand

Subject: [patch] one extra (incorrect) test in mask_ack_irq()

preempt-irqs-core.patch added an incorrect check for the existence of
desc->chip->ack to mask_ack_irq()

Signed-off-by: Frank Rowand <[email protected]>

--- linux-2.6.29-rc7/kernel/irq/chip.c 2009-03-18 17:58:03.000000000 -0800
+++ linux-2.6.29-rc7_new/kernel/irq/chip.c 2009-03-18 17:59:15.000000000 -0800
@@ -293,7 +293,6 @@ static inline void mask_ack_irq(struct i
if (desc->chip->mask_ack)
desc->chip->mask_ack(irq);
else {
- if (desc->chip->ack)
if (desc->chip->mask)
desc->chip->mask(irq);
if (desc->chip->ack)

2009-03-19 07:33:24

by Thomas Gleixner

Subject: Re: [patch] one extra (incorrect) test in mask_ack_irq()

Frank,

On Wed, 18 Mar 2009, Frank Rowand wrote:
> preempt-irqs-core.patch added an incorrect check for the existence of
> desc->chip->ack to mask_ack_irq()

Applied. Thanks,

tglx