2009-03-25 12:34:32

by Frank Seidel

Subject: [PATCH] trivial: remove warning from arch/x86/kernel/kprobes.c

From: Frank Seidel <[email protected]>

Remove warning (makes integer from pointer without a cast)
from build messages.

Signed-off-by: Frank Seidel <[email protected]>
---
arch/x86/kernel/kprobes.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- a/arch/x86/kernel/kprobes.c
+++ b/arch/x86/kernel/kprobes.c
@@ -193,7 +193,7 @@ static int __kprobes can_boost(kprobe_op
kprobe_opcode_t opcode;
kprobe_opcode_t *orig_opcodes = opcodes;

- if (search_exception_tables(opcodes))
+ if (search_exception_tables((unsigned long)opcodes))
return 0; /* Page fault may occur on this address. */

retry:

2009-03-25 12:40:28

by Ingo Molnar

Subject: Re: [PATCH] trivial: remove warning from arch/x86/kernel/kprobes.c

* Frank Seidel <[email protected]> wrote:

> From: Frank Seidel <[email protected]>
>
> Remove warning (makes integer from pointer without a cast)
> from build messages.
>
> Signed-off-by: Frank Seidel <[email protected]>
> ---
> arch/x86/kernel/kprobes.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/arch/x86/kernel/kprobes.c
> +++ b/arch/x86/kernel/kprobes.c
> @@ -193,7 +193,7 @@ static int __kprobes can_boost(kprobe_op
> kprobe_opcode_t opcode;
> kprobe_opcode_t *orig_opcodes = opcodes;
>
> - if (search_exception_tables(opcodes))
> + if (search_exception_tables((unsigned long)opcodes))
> return 0; /* Page fault may occur on this address. */

fixed in the x86 tree:

http://people.redhat.com/mingo/tip.git/README

a couple of days ago. (see the commit below)

Ingo

---------->
>From cde5edbda8ba7d600154ce4171125a48e4d2a21b Mon Sep 17 00:00:00 2001
From: Jaswinder Singh Rajput <[email protected]>
Date: Wed, 18 Mar 2009 17:37:45 +0530
Subject: [PATCH] x86: kprobes.c fix compilation warning
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit

arch/x86/kernel/kprobes.c:196: warning: passing argument 1 of ‘search_exception_tables’ makes integer from pointer without a cast

Signed-off-by: Jaswinder Singh Rajput <[email protected]>
Cc: Linus Torvalds <[email protected]>
LKML-Reference:<[email protected]>
LKML-Reference: <[email protected]>
Signed-off-by: Ingo Molnar <[email protected]>
---
arch/x86/kernel/kprobes.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/kernel/kprobes.c b/arch/x86/kernel/kprobes.c
index 4558dd3..55b9461 100644
--- a/arch/x86/kernel/kprobes.c
+++ b/arch/x86/kernel/kprobes.c
@@ -193,7 +193,7 @@ static int __kprobes can_boost(kprobe_opcode_t *opcodes)
kprobe_opcode_t opcode;
kprobe_opcode_t *orig_opcodes = opcodes;

- if (search_exception_tables(opcodes))
+ if (search_exception_tables((unsigned long)opcodes))
return 0; /* Page fault may occur on this address. */

retry:

2009-03-25 12:44:25

by Frank Seidel

Subject: Re: [PATCH] trivial: remove warning from arch/x86/kernel/kprobes.c

Ingo Molnar wrote.
> fixed in the x86 tree:

Oops, ok, sorry for the noise..

Frank

2009-03-25 13:23:52

by Masami Hiramatsu

Subject: Re: [PATCH] trivial: remove warning from arch/x86/kernel/kprobes.c

Frank Seidel wrote:
> Ingo Molnar wrote.
>> fixed in the x86 tree:
>
> Oops, ok, sorry for the noise..

Anyway, thank you for fixing!


--
Masami Hiramatsu

Software Engineer
Hitachi Computer Products (America) Inc.
Software Solutions Division

e-mail: [email protected]