2009-04-08 16:40:33

by Alan Jenkins

Subject: usual_tables: module license 'unspecified' taints kernel.

Hi, I see this regression in v2.6.30-rc1. I end up with a module
"usual_tables.ko", which is loaded on boot and causes the kernel to
complain about an unspecified license. See subject for the exact error
message.

I have

CONFIG_USB_STORAGE=m
CONFIG_USB_LIBUSUAL=y

Also, usb-storage doesn't seem to get loaded automatically, as it did in
2.6.29 with the same configs.

Thanks
Alan

2009-04-08 16:56:41

by Alan Jenkins

Subject: Re: usual_tables: module license 'unspecified' taints kernel.

Alan Jenkins wrote:
> Hi, I see this regression in v2.6.30-rc1. I end up with a module
> "usual_tables.ko", which is loaded on boot and causes the kernel to
> complain about an unspecified license. See subject for the exact
> error message.
>
> I have
>
> CONFIG_USB_STORAGE=m
> CONFIG_USB_LIBUSUAL=y
>

> Also, usb-storage doesn't seem to get loaded automatically, as it did
> in 2.6.29 with the same configs.
>
Hmm, seems someone else broke request_module(). So don't worry about
this last issue - I'm sure it will get fixed :-).

2009-04-08 22:31:51

by Alan Stern

Subject: Re: usual_tables: module license 'unspecified' taints kernel.

On Wed, 8 Apr 2009, Alan Jenkins wrote:

> Hi, I see this regression in v2.6.30-rc1. I end up with a module
> "usual_tables.ko", which is loaded on boot and causes the kernel to
> complain about an unspecified license. See subject for the exact error
> message.
>
> I have
>
> CONFIG_USB_STORAGE=m
> CONFIG_USB_LIBUSUAL=y

This looks like a mistake in the Makefile. Does the patch below fix
the problem?

Alan Stern


Index: usb-2.6/drivers/usb/storage/Makefile
===================================================================
--- usb-2.6.orig/drivers/usb/storage/Makefile
+++ usb-2.6/drivers/usb/storage/Makefile
@@ -17,7 +17,8 @@ usb-storage-objs := scsiglue.o protocol.
ifeq ($(CONFIG_USB_LIBUSUAL),)
usb-storage-objs += usual-tables.o
else
- obj-$(CONFIG_USB) += libusual.o usual-tables.o
+ obj-$(CONFIG_USB) += usb-libusual.o
+ usb-libusual-objs := libusual.o usual-tables.o
endif

obj-$(CONFIG_USB_STORAGE_ALAUDA) += ums-alauda.o

2009-04-09 09:54:51

by Alan Jenkins

Subject: Re: usual_tables: module license 'unspecified' taints kernel.

Alan Stern wrote:
> On Wed, 8 Apr 2009, Alan Jenkins wrote:
>
>
>> Hi, I see this regression in v2.6.30-rc1. I end up with a module
>> "usual_tables.ko", which is loaded on boot and causes the kernel to
>> complain about an unspecified license. See subject for the exact error
>> message.
>>
>> I have
>>
>> CONFIG_USB_STORAGE=m
>> CONFIG_USB_LIBUSUAL=y
>>
>
> This looks like a mistake in the Makefile. Does the patch below fix
> the problem?
>
> Alan Stern
>

Yes. Thanks!