2009-04-22 19:06:27

by Coly Li

Subject: [PATCH 6/7] parisc: add parameter to read_cr16()

This patch modifies parameter of au1x_counter1_read() from 'void' to 'struct
clocksource *cs', which fixes compile warning for incompatible parameter type.

Signed-off-by: Coly Li <[email protected]>
Cc: Helge Deller <[email protected]>
Cc: Ingo Molnar <[email protected]>
---
arch/parisc/kernel/time.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/parisc/kernel/time.c b/arch/parisc/kernel/time.c
index d4dd056..d97d07f 100644
--- a/arch/parisc/kernel/time.c
+++ b/arch/parisc/kernel/time.c
@@ -173,7 +173,7 @@ EXPORT_SYMBOL(profile_pc);

/* clock source code */

-static cycle_t read_cr16(void)
+static cycle_t read_cr16(struct clocksource *cs)
{
return get_cycles();
}

--
Coly Li
SuSE Labs

2009-04-22 21:39:40

by Helge Deller

Subject: Re: [PATCH 6/7] parisc: add parameter to read_cr16()

Coly Li wrote:
> This patch modifies parameter of au1x_counter1_read() from 'void' to 'struct
> clocksource *cs', which fixes compile warning for incompatible parameter type.
>
> Signed-off-by: Coly Li <[email protected]>
> Cc: Helge Deller <[email protected]>

Patch is good.
Thanks!

Acked-by: Helge Deller <[email protected]>


> Cc: Ingo Molnar <[email protected]>
> ---
> arch/parisc/kernel/time.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/parisc/kernel/time.c b/arch/parisc/kernel/time.c
> index d4dd056..d97d07f 100644
> --- a/arch/parisc/kernel/time.c
> +++ b/arch/parisc/kernel/time.c
> @@ -173,7 +173,7 @@ EXPORT_SYMBOL(profile_pc);
>
> /* clock source code */
>
> -static cycle_t read_cr16(void)
> +static cycle_t read_cr16(struct clocksource *cs)
> {
> return get_cycles();
> }
>