2009-04-27 17:21:30

by Mark Brown

Subject: [PATCH] regulator: Move regulator drivers to subsys_initcall()

Regulators need to be available early in init in order to allow them
to be available for consumers when requested. This is generally done
by registering them at subsys_initcall() time but not all regulator
drivers have done that. Convert these drivers to do so in order to
mimimise future support.

Signed-off-by: Mark Brown <[email protected]>
---
drivers/regulator/da903x.c | 2 +-
drivers/regulator/fixed.c | 2 +-
drivers/regulator/pcf50633-regulator.c | 2 +-
drivers/regulator/wm8400-regulator.c | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/regulator/da903x.c b/drivers/regulator/da903x.c
index 72b1549..2a491bf 100644
--- a/drivers/regulator/da903x.c
+++ b/drivers/regulator/da903x.c
@@ -504,7 +504,7 @@ static int __init da903x_regulator_init(void)
{
return platform_driver_register(&da903x_regulator_driver);
}
-module_init(da903x_regulator_init);
+subsys_initcall(da903x_regulator_init);

static void __exit da903x_regulator_exit(void)
{
diff --git a/drivers/regulator/fixed.c b/drivers/regulator/fixed.c
index 23d5546..6e0bede 100644
--- a/drivers/regulator/fixed.c
+++ b/drivers/regulator/fixed.c
@@ -117,7 +117,7 @@ static int __init regulator_fixed_voltage_init(void)
{
return platform_driver_register(&regulator_fixed_voltage_driver);
}
-module_init(regulator_fixed_voltage_init);
+subsys_initcall(regulator_fixed_voltage_init);

static void __exit regulator_fixed_voltage_exit(void)
{
diff --git a/drivers/regulator/pcf50633-regulator.c b/drivers/regulator/pcf50633-regulator.c
index cd761d8..8e14900 100644
--- a/drivers/regulator/pcf50633-regulator.c
+++ b/drivers/regulator/pcf50633-regulator.c
@@ -316,7 +316,7 @@ static int __init pcf50633_regulator_init(void)
{
return platform_driver_register(&pcf50633_regulator_driver);
}
-module_init(pcf50633_regulator_init);
+subsys_initcall(pcf50633_regulator_init);

static void __exit pcf50633_regulator_exit(void)
{
diff --git a/drivers/regulator/wm8400-regulator.c b/drivers/regulator/wm8400-regulator.c
index 1574260..01a6c95 100644
--- a/drivers/regulator/wm8400-regulator.c
+++ b/drivers/regulator/wm8400-regulator.c
@@ -380,7 +380,7 @@ static int __init wm8400_regulator_init(void)
{
return platform_driver_register(&wm8400_regulator_driver);
}
-module_init(wm8400_regulator_init);
+subsys_initcall(wm8400_regulator_init);

static void __exit wm8400_regulator_exit(void)
{
--
1.6.2.4

2009-04-28 05:18:36

by Mike Rapoport

Subject: Re: [PATCH] regulator: Move regulator drivers to subsys_initcall()

Mark Brown wrote:
> Regulators need to be available early in init in order to allow them
> to be available for consumers when requested. This is generally done
> by registering them at subsys_initcall() time but not all regulator
> drivers have done that. Convert these drivers to do so in order to
> mimimise future support.
>
> Signed-off-by: Mark Brown <[email protected]>
> ---
> drivers/regulator/da903x.c | 2 +-
> drivers/regulator/fixed.c | 2 +-
> drivers/regulator/pcf50633-regulator.c | 2 +-
> drivers/regulator/wm8400-regulator.c | 2 +-
> 4 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/regulator/da903x.c b/drivers/regulator/da903x.c
> index 72b1549..2a491bf 100644
> --- a/drivers/regulator/da903x.c
> +++ b/drivers/regulator/da903x.c
> @@ -504,7 +504,7 @@ static int __init da903x_regulator_init(void)
> {
> return platform_driver_register(&da903x_regulator_driver);
> }
> -module_init(da903x_regulator_init);
> +subsys_initcall(da903x_regulator_init);

For DA903x part

Acked-by: Mike Rapoport <[email protected]>

> static void __exit da903x_regulator_exit(void)
> {
> diff --git a/drivers/regulator/fixed.c b/drivers/regulator/fixed.c
> index 23d5546..6e0bede 100644
> --- a/drivers/regulator/fixed.c
> +++ b/drivers/regulator/fixed.c
> @@ -117,7 +117,7 @@ static int __init regulator_fixed_voltage_init(void)
> {
> return platform_driver_register(&regulator_fixed_voltage_driver);
> }
> -module_init(regulator_fixed_voltage_init);
> +subsys_initcall(regulator_fixed_voltage_init);
>
> static void __exit regulator_fixed_voltage_exit(void)
> {
> diff --git a/drivers/regulator/pcf50633-regulator.c b/drivers/regulator/pcf50633-regulator.c
> index cd761d8..8e14900 100644
> --- a/drivers/regulator/pcf50633-regulator.c
> +++ b/drivers/regulator/pcf50633-regulator.c
> @@ -316,7 +316,7 @@ static int __init pcf50633_regulator_init(void)
> {
> return platform_driver_register(&pcf50633_regulator_driver);
> }
> -module_init(pcf50633_regulator_init);
> +subsys_initcall(pcf50633_regulator_init);
>
> static void __exit pcf50633_regulator_exit(void)
> {
> diff --git a/drivers/regulator/wm8400-regulator.c b/drivers/regulator/wm8400-regulator.c
> index 1574260..01a6c95 100644
> --- a/drivers/regulator/wm8400-regulator.c
> +++ b/drivers/regulator/wm8400-regulator.c
> @@ -380,7 +380,7 @@ static int __init wm8400_regulator_init(void)
> {
> return platform_driver_register(&wm8400_regulator_driver);
> }
> -module_init(wm8400_regulator_init);
> +subsys_initcall(wm8400_regulator_init);
>
> static void __exit wm8400_regulator_exit(void)
> {

--
Sincerely yours,
Mike.

2009-04-28 11:19:16

by Liam Girdwood

Subject: Re: [PATCH] regulator: Move regulator drivers to subsys_initcall()

On Mon, 2009-04-27 at 18:21 +0100, Mark Brown wrote:
> Regulators need to be available early in init in order to allow them
> to be available for consumers when requested. This is generally done
> by registering them at subsys_initcall() time but not all regulator
> drivers have done that. Convert these drivers to do so in order to
> mimimise future support.
>
> Signed-off-by: Mark Brown <[email protected]>
> ---
> drivers/regulator/da903x.c | 2 +-
> drivers/regulator/fixed.c | 2 +-
> drivers/regulator/pcf50633-regulator.c | 2 +-
> drivers/regulator/wm8400-regulator.c | 2 +-
> 4 files changed, 4 insertions(+), 4 deletions(-)
>

Applied.

Thanks

Liam