2009-04-28 17:40:35

by Mario Limonciello

[permalink] [raw]
Subject: [PATCH] Ignore garbage in dell-wmi events

Hi:

In debugging with some future machines that actually contain BIOS level
support for dell-wmi, I've determined that the upper half of the data
that comes back from wmi_get_event_data may sometimes contain extra
information that isn't currently relevant when pulling scan codes out of
the data. This causes dell-wmi to improperly respond to these events.

I'm attaching a patch (Exchange would munge up the line breaks otherwise).

Thanks,

--
Mario Limonciello
*Dell | Linux Engineering*
[email protected]

Attachments:
dell-wmi-mask-buffer.patch (673.00 B)
 signature.asc (260.00 B)
OpenPGP digital signature Download all attachments

2009-04-29 16:55:37

by Matthew Garrett

[permalink] [raw]
Subject: Re: [PATCH] Ignore garbage in dell-wmi events

Hi Mario,

Can you add your signed-off-by: for this?

Thanks,
--
Matthew Garrett | [email protected]

2009-04-29 18:14:11

by Mario Limonciello

[permalink] [raw]
Subject: Re: [PATCH] Ignore garbage in dell-wmi events

Sure. Do you want me to resend all of them to add that?

Matthew Garrett wrote:
> Hi Mario,
>
> Can you add your signed-off-by: for this?
>
> Thanks,
>
Regards,

--
Mario Limonciello
*Dell | Linux Engineering*
[email protected]

Attachments:
dell-wmi-mask-buffer.patch (740.00 B)
 signature.asc (260.00 B)
OpenPGP digital signature Download all attachments

2009-04-29 18:28:39

by Matthew Garrett

[permalink] [raw]
Subject: Re: [PATCH] Ignore garbage in dell-wmi events

I think just this and the additional keycodes one for now.

--
Matthew Garrett | [email protected]

2009-04-29 20:17:21

by Andrew Morton

[permalink] [raw]
Subject: Re: [PATCH] Ignore garbage in dell-wmi events

On Tue, 28 Apr 2009 12:40:34 -0500
Mario Limonciello <[email protected]> wrote:

> In debugging with some future machines that actually contain BIOS level
> support for dell-wmi, I've determined that the upper half of the data
> that comes back from wmi_get_event_data may sometimes contain extra
> information that isn't currently relevant when pulling scan codes out of
> the data. This causes dell-wmi to improperly respond to these events.
>
> I'm attaching a patch (Exchange would munge up the line breaks otherwise).

Can you please send along a Signed-off-by: for this patch?
Documentation/SubmittingPatches explains what it's all about.

Thanks.