2022-10-25 11:22:03

by Rahul Tanwar

Subject: [PATCH 1/1] clk: mxl: Fix smatch static checker warning

Commit 036177310bac: ("clk: mxl: Switch from direct readl/writel based IO to
regmap based IO") introduced code resulting in below warning issued by the
smatch static checker.

drivers/clk/x86/clk-lgm.c:441 lgm_cgu_probe()
warn: passing zero to 'PTR_ERR'

Fix the warning by replacing incorrect IS_ERR_OR_NULL() with IS_ERR().

Fixes: 036177310bac: ("clk: mxl: Switch from direct readl/writel based IO to
regmap based IO")
Reported-by: Dan Carpenter <[email protected]>
Signed-off-by: Rahul Tanwar <[email protected]>
---
drivers/clk/x86/clk-lgm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/x86/clk-lgm.c b/drivers/clk/x86/clk-lgm.c
index 4de77b2c750d..f69455dd1c98 100644
--- a/drivers/clk/x86/clk-lgm.c
+++ b/drivers/clk/x86/clk-lgm.c
@@ -436,7 +436,7 @@ static int lgm_cgu_probe(struct platform_device *pdev)
ctx->clk_data.num = CLK_NR_CLKS;

ctx->membase = syscon_node_to_regmap(np);
- if (IS_ERR_OR_NULL(ctx->membase)) {
+ if (IS_ERR(ctx->membase)) {
dev_err(dev, "Failed to get clk CGU iomem\n");
return PTR_ERR(ctx->membase);
}
--
2.17.1

2022-10-27 01:11:48

by Stephen Boyd

Subject: Re: [PATCH 1/1] clk: mxl: Fix smatch static checker warning

Quoting Rahul Tanwar (2022-10-25 04:03:57)
> Commit 036177310bac: ("clk: mxl: Switch from direct readl/writel based IO to
> regmap based IO") introduced code resulting in below warning issued by the
> smatch static checker.
>
> drivers/clk/x86/clk-lgm.c:441 lgm_cgu_probe()
> warn: passing zero to 'PTR_ERR'
>
> Fix the warning by replacing incorrect IS_ERR_OR_NULL() with IS_ERR().
>
> Fixes: 036177310bac: ("clk: mxl: Switch from direct readl/writel based IO to
> regmap based IO")
> Reported-by: Dan Carpenter <[email protected]>
> Signed-off-by: Rahul Tanwar <[email protected]>
> ---

Applied to clk-next

BTW, please don't send a cover letter for single patches.