2018-09-10 18:40:59

by Neil Armstrong

[permalink] [raw]
Subject: [PATCH] arm64: dts: meson-axg: use the proper compatible for ethmac

Use the correct compatible for the AXG ethernet mac node.

Signed-off-by: Neil Armstrong <[email protected]>
---
arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
index 32f6dca..75f4ca7 100644
--- a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
@@ -525,7 +525,7 @@
};

ethmac: ethernet@ff3f0000 {
- compatible = "amlogic,meson-gxbb-dwmac", "snps,dwmac";
+ compatible = "amlogic,meson-axg-dwmac", "snps,dwmac";
reg = <0x0 0xff3f0000 0x0 0x10000
0x0 0xff634540 0x0 0x8>;
interrupts = <GIC_SPI 8 IRQ_TYPE_EDGE_RISING>;
--
2.7.4



2018-09-10 18:45:10

by Martin Blumenstingl

[permalink] [raw]
Subject: Re: [PATCH] arm64: dts: meson-axg: use the proper compatible for ethmac

On Mon, Sep 10, 2018 at 8:39 PM Neil Armstrong <[email protected]> wrote:
>
> Use the correct compatible for the AXG ethernet mac node.
>
> Signed-off-by: Neil Armstrong <[email protected]>
I wonder if you should add a "Fixes" tag. apart from that:

Acked-by: Martin Blumenstingl <[email protected]>

2018-09-11 13:28:07

by Neil Armstrong

[permalink] [raw]
Subject: Re: [PATCH] arm64: dts: meson-axg: use the proper compatible for ethmac

On 10/09/2018 20:44, Martin Blumenstingl wrote:
> On Mon, Sep 10, 2018 at 8:39 PM Neil Armstrong <[email protected]> wrote:
>>
>> Use the correct compatible for the AXG ethernet mac node.
>>
>> Signed-off-by: Neil Armstrong <[email protected]>
> I wonder if you should add a "Fixes" tag. apart from that:
>
> Acked-by: Martin Blumenstingl <[email protected]>
>

Hi Martin,

I'm not sure when the dwmac changes has been merged, and anyway the only board upstreamed uses RGMII which has the same bits for the glue register.

Neil

2018-09-13 04:56:37

by Kevin Hilman

[permalink] [raw]
Subject: Re: [PATCH] arm64: dts: meson-axg: use the proper compatible for ethmac

Neil Armstrong <[email protected]> writes:

> Use the correct compatible for the AXG ethernet mac node.
>
> Signed-off-by: Neil Armstrong <[email protected]>

Applied to v4.20/dt64 with Martin's ack,

Thanks,

Kevin