2021-03-18 15:53:41

by Johan Hovold

Subject: [PATCH 3/7] USB: cdc-acm: drop redundant driver-data assignment

The interface driver data has already been set by
usb_driver_claim_interface() so drop the redundant subsequent
assignment.

Signed-off-by: Johan Hovold <[email protected]>
---
drivers/usb/class/cdc-acm.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c
index dfc2480add91..36dd1e05e455 100644
--- a/drivers/usb/class/cdc-acm.c
+++ b/drivers/usb/class/cdc-acm.c
@@ -1487,7 +1487,6 @@ static int acm_probe(struct usb_interface *intf,
acm_set_line(acm, &acm->line);

usb_driver_claim_interface(&acm_driver, data_interface, acm);
- usb_set_intfdata(data_interface, acm);

tty_dev = tty_port_register_device(&acm->port, acm_tty_driver, minor,
&control_interface->dev);
--
2.26.2

2021-03-22 09:42:09

by Oliver Neukum

Subject: Re: [PATCH 3/7] USB: cdc-acm: drop redundant driver-data assignment

Am Donnerstag, den 18.03.2021, 16:51 +0100 schrieb Johan Hovold:
> The interface driver data has already been set by
> usb_driver_claim_interface() so drop the redundant subsequent
> assignment.
>
> Signed-off-by: Johan Hovold <[email protected]>
Acked-by: Oliver Neukum <[email protected]>