2009-06-05 09:18:43

by Gui, Jianfeng/归 剑峰

Subject: Re: [PATCH 10/20] io-conroller: Prepare elevator layer for single queue schedulers

Vivek Goyal wrote:
> + e->ops->elevator_free_sched_queue_fn(e,
> + sched_q);
> + sched_q = NULL;
> + goto queue_fail;
> + }
> + }
> +
> + elv_init_ioq(e, ioq, iog, sched_q, IOPRIO_CLASS_BE, 4, 1);

It's better to use IOPRIO_NORM here.

Signed-off-by: Gui Jianfeng <[email protected]>
---
block/elevator-fq.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/block/elevator-fq.c b/block/elevator-fq.c
index f1179aa..3c5f9da 100644
--- a/block/elevator-fq.c
+++ b/block/elevator-fq.c
@@ -2403,7 +2403,8 @@ alloc_ioq:
}
}

- elv_init_ioq(e, ioq, iog, sched_q, IOPRIO_CLASS_BE, 4, 1);
+ elv_init_ioq(e, ioq, iog, sched_q, IOPRIO_CLASS_BE,
+ IOPRIO_NORM, 1);
io_group_set_ioq(iog, ioq);
elv_mark_ioq_sync(ioq);
elv_get_iog(iog);
--
1.5.4.rc3

2009-06-05 13:24:20

by Vivek Goyal

Subject: Re: [PATCH 10/20] io-conroller: Prepare elevator layer for single queue schedulers

On Fri, Jun 05, 2009 at 05:17:07PM +0800, Gui Jianfeng wrote:
> Vivek Goyal wrote:
> > + e->ops->elevator_free_sched_queue_fn(e,
> > + sched_q);
> > + sched_q = NULL;
> > + goto queue_fail;
> > + }
> > + }
> > +
> > + elv_init_ioq(e, ioq, iog, sched_q, IOPRIO_CLASS_BE, 4, 1);
>
> It's better to use IOPRIO_NORM here.
>

Sure. Queued up for next posting.

Thanks
Vivek

> Signed-off-by: Gui Jianfeng <[email protected]>
> ---
> block/elevator-fq.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/block/elevator-fq.c b/block/elevator-fq.c
> index f1179aa..3c5f9da 100644
> --- a/block/elevator-fq.c
> +++ b/block/elevator-fq.c
> @@ -2403,7 +2403,8 @@ alloc_ioq:
> }
> }
>
> - elv_init_ioq(e, ioq, iog, sched_q, IOPRIO_CLASS_BE, 4, 1);
> + elv_init_ioq(e, ioq, iog, sched_q, IOPRIO_CLASS_BE,
> + IOPRIO_NORM, 1);
> io_group_set_ioq(iog, ioq);
> elv_mark_ioq_sync(ioq);
> elv_get_iog(iog);
> --
> 1.5.4.rc3