2009-06-08 07:46:14

by Gui, Jianfeng/归 剑峰

Subject: Re: [PATCH 02/20] io-controller: Common flat fair queuing code in elevaotor layer

Vivek Goyal wrote:
...
> +
> +static inline pid_t elv_ioq_pid(struct io_queue *ioq)
> +{
> + return ioq->pid;
> +}
> +
> +static inline unsigned long elv_ioq_ttime_mean(struct io_queue *ioq)
> +{
> + return ioq->ttime_mean;
> +}
> +
> +static inline unsigned long elv_ioq_sample_valid(struct io_queue *ioq)
> +{
> + return ioq_sample_valid(ioq->ttime_samples);
> +}
> +

These three functions are dead now, just remove them.

Signed-off-by: Gui Jianfeng <[email protected]>
---
block/elevator-fq.h | 15 ---------------
1 files changed, 0 insertions(+), 15 deletions(-)

diff --git a/block/elevator-fq.h b/block/elevator-fq.h
index 24a3af9..b2bb11a 100644
--- a/block/elevator-fq.h
+++ b/block/elevator-fq.h
@@ -452,21 +452,6 @@ static inline int elv_ioq_nr_queued(struct io_queue *ioq)
return ioq->nr_queued;
}

-static inline pid_t elv_ioq_pid(struct io_queue *ioq)
-{
- return ioq->pid;
-}
-
-static inline unsigned long elv_ioq_ttime_mean(struct io_queue *ioq)
-{
- return ioq->ttime_mean;
-}
-
-static inline unsigned long elv_ioq_sample_valid(struct io_queue *ioq)
-{
- return ioq_sample_valid(ioq->ttime_samples);
-}
-
static inline void elv_get_ioq(struct io_queue *ioq)
{
atomic_inc(&ioq->ref);
--
1.5.4.rc3

2009-06-08 13:57:51

by Vivek Goyal

Subject: Re: [PATCH 02/20] io-controller: Common flat fair queuing code in elevaotor layer

On Mon, Jun 08, 2009 at 03:44:31PM +0800, Gui Jianfeng wrote:
> Vivek Goyal wrote:
> ...
> > +
> > +static inline pid_t elv_ioq_pid(struct io_queue *ioq)
> > +{
> > + return ioq->pid;
> > +}
> > +
> > +static inline unsigned long elv_ioq_ttime_mean(struct io_queue *ioq)
> > +{
> > + return ioq->ttime_mean;
> > +}
> > +
> > +static inline unsigned long elv_ioq_sample_valid(struct io_queue *ioq)
> > +{
> > + return ioq_sample_valid(ioq->ttime_samples);
> > +}
> > +
>
> These three functions are dead now, just remove them.
>

Thanks Gui. queued up for next posting.

Thanks
Vivek

> Signed-off-by: Gui Jianfeng <[email protected]>
> ---
> block/elevator-fq.h | 15 ---------------
> 1 files changed, 0 insertions(+), 15 deletions(-)
>
> diff --git a/block/elevator-fq.h b/block/elevator-fq.h
> index 24a3af9..b2bb11a 100644
> --- a/block/elevator-fq.h
> +++ b/block/elevator-fq.h
> @@ -452,21 +452,6 @@ static inline int elv_ioq_nr_queued(struct io_queue *ioq)
> return ioq->nr_queued;
> }
>
> -static inline pid_t elv_ioq_pid(struct io_queue *ioq)
> -{
> - return ioq->pid;
> -}
> -
> -static inline unsigned long elv_ioq_ttime_mean(struct io_queue *ioq)
> -{
> - return ioq->ttime_mean;
> -}
> -
> -static inline unsigned long elv_ioq_sample_valid(struct io_queue *ioq)
> -{
> - return ioq_sample_valid(ioq->ttime_samples);
> -}
> -
> static inline void elv_get_ioq(struct io_queue *ioq)
> {
> atomic_inc(&ioq->ref);
> --
> 1.5.4.rc3