Hello,
the README simply points to a wrong/non-existent directory where the default configurations are not suited, hence the patch.
Signed-off-by: Patrick Ringl <[email protected]>
-----
--- linux.orig/README 2009-06-10 05:05:27.000000000 +0200
+++ linux/README 2009-06-12 10:46:15.000000000 +0200
@@ -175,7 +175,7 @@
Like above, but avoids cluttering the screen
with questions already answered.
"make defconfig" Create a ./.config file by using the default
- symbol values from arch/$ARCH/defconfig.
+ symbol values from arch/$ARCH/configs/*_defconfig.
"make allyesconfig"
Create a ./.config file by setting symbol
values to 'y' as much as possible.
-----
regards,
Patrick
On Friday 12 June 2009, Patrick Ringl wrote:
> the README simply points to a wrong/non-existent directory where the default
> configurations are not suited, hence the patch.
On six architectures, it's still the right directory, your patch breaks it.
> Signed-off-by: Patrick Ringl <[email protected]>
>
> --- linux.orig/README 2009-06-10 05:05:27.000000000 +0200
> +++ linux/README 2009-06-12 10:46:15.000000000 +0200
> @@ -175,7 +175,7 @@
> Like above, but avoids cluttering the screen
> with questions already answered.
> "make defconfig" Create a ./.config file by using the default
> - symbol values from arch/$ARCH/defconfig.
> + symbol values from arch/$ARCH/configs/*_defconfig.
> "make allyesconfig"
> Create a ./.config file by setting symbol
> values to 'y' as much as possible.
You could write e.g.
default symbol values from one of arch/{$ARCH}/defconfig or
arch/${ARCH}/configs/${PLATFORM}_defconfig, depending on
the architecture.
It would also be consistent to list the specific defconfigs here, like
"make ${PLATFORM}_defconfig"
Create a ./.config file by using the default
symbol values from
arch/${ARCH}/configs/${PLATFORM}_defconfig.
Use "make help" to see a list of the available
platforms on your architecture.
Not also that your patch should be merged through a subsystem maintainer.
If you don't know who that is, use scripts/get_maintainer.pl.
For scripts/kconfig/* and README it suggests sending it to Sam, Roman and
[email protected], which sounds right.
Arnd <><
Arnd Bergmann wrote:
> On Friday 12 June 2009, Patrick Ringl wrote:
>
>> the README simply points to a wrong/non-existent directory where the default
>> configurations are not suited, hence the patch.
>>
>
> On six architectures, it's still the right directory, your patch breaks it.
>
>
Darn, I used 'find' to ensure the structure is consistent, stupidly I
didn't check wether the amount of fitting cases equals the amount of
platforms at all, thus I did miss those who do not fit.
>> Signed-off-by: Patrick Ringl <[email protected]>
>>
>> --- linux.orig/README 2009-06-10 05:05:27.000000000 +0200
>> +++ linux/README 2009-06-12 10:46:15.000000000 +0200
>> @@ -175,7 +175,7 @@
>> Like above, but avoids cluttering the screen
>> with questions already answered.
>> "make defconfig" Create a ./.config file by using the default
>> - symbol values from arch/$ARCH/defconfig.
>> + symbol values from arch/$ARCH/configs/*_defconfig.
>> "make allyesconfig"
>> Create a ./.config file by setting symbol
>> values to 'y' as much as possible.
>>
>
> You could write e.g.
>
> default symbol values from one of arch/{$ARCH}/defconfig or
> arch/${ARCH}/configs/${PLATFORM}_defconfig, depending on
> the architecture.
>
> It would also be consistent to list the specific defconfigs here, like
>
> "make ${PLATFORM}_defconfig"
> Create a ./.config file by using the default
> symbol values from
> arch/${ARCH}/configs/${PLATFORM}_defconfig.
> Use "make help" to see a list of the available
> platforms on your architecture.
>
>
I really like that approach! :-)
> Not also that your patch should be merged through a subsystem maintainer.
> If you don't know who that is, use scripts/get_maintainer.pl.
> For scripts/kconfig/* and README it suggests sending it to Sam, Roman and
> [email protected], which sounds right.
>
> Arnd <>
Right, I honestly didn't know about that useful tool (if the LKML-FAQ
tells about this, I must've missed it). Thanks for your short review and
the revealing of my overhasty blooper.
I am going to resend the patch with your suggestions above soon.
regards,
Patrick
Hello again,
after Arnd's short review and appropriate suggestions of change (thank
you), here is an updated version of my earlier patch:
Signed-off-by: Patrick Ringl <[email protected]>
<---->
--- linux.orig/README 2009-06-10 05:05:27.000000000 +0200
+++ linux/README 2009-06-12 13:47:38.000000000 +0200
@@ -175,7 +175,15 @@
Like above, but avoids cluttering the screen
with questions already answered.
"make defconfig" Create a ./.config file by using the default
- symbol values from arch/$ARCH/defconfig.
+ symbol values from either arch/$ARCH/defconfig
+ or arch/$ARCH/configs/${PLATFORM}_defconfig,
+ depending on the architecture.
+ "make ${PLATFORM}_defconfig"
+ Create a ./.config file by using the default
+ symbol values from
+ arch/$ARCH/configs/${PLATFORM}_defconfig.
+ Use "make help" to get a list of all available
+ platforms of your architecture.
"make allyesconfig"
Create a ./.config file by setting symbol
values to 'y' as much as possible.
<---->
regards,
Patrick
On Fri, Jun 12, 2009 at 01:58:36PM +0200, Patrick Ringl wrote:
> Hello again,
>
> after Arnd's short review and appropriate suggestions of change (thank
> you), here is an updated version of my earlier patch:
>
>
> Signed-off-by: Patrick Ringl <[email protected]>
>
> <---->
>
> --- linux.orig/README 2009-06-10 05:05:27.000000000 +0200
> +++ linux/README 2009-06-12 13:47:38.000000000 +0200
> @@ -175,7 +175,15 @@
> Like above, but avoids cluttering the screen
> with questions already answered.
> "make defconfig" Create a ./.config file by using the default
> - symbol values from arch/$ARCH/defconfig.
> + symbol values from either arch/$ARCH/defconfig
> + or arch/$ARCH/configs/${PLATFORM}_defconfig,
> + depending on the architecture.
> + "make ${PLATFORM}_defconfig"
> + Create a ./.config file by using the default
> + symbol values from
> + arch/$ARCH/configs/${PLATFORM}_defconfig.
> + Use "make help" to get a list of all available
> + platforms of your architecture.
> "make allyesconfig"
> Create a ./.config file by setting symbol
> values to 'y' as much as possible.
Applied. I had to apply it manually for some reason.
Sam