2009-06-17 16:00:00

by Alan Stern

Subject: [PATCH] driver core: remove unheeded warning about driver methods

This patch (as1263) removes a warning which has been present for so
long, and consistently ignored, that it obviously is not doing any
good. It gets triggered on pretty much every boot by the SCSI disk
and cdrom drivers. Evidently nobody cares.

Signed-off-by: Alan Stern <[email protected]>

---

Index: usb-2.6/drivers/base/driver.c
===================================================================
--- usb-2.6.orig/drivers/base/driver.c
+++ usb-2.6/drivers/base/driver.c
@@ -225,12 +225,6 @@ int driver_register(struct device_driver

BUG_ON(!drv->bus->p);

- if ((drv->bus->probe && drv->probe) ||
- (drv->bus->remove && drv->remove) ||
- (drv->bus->shutdown && drv->shutdown))
- printk(KERN_WARNING "Driver '%s' needs updating - please use "
- "bus_type methods\n", drv->name);
-
other = driver_find(drv->name, drv->bus);
if (other) {
put_driver(other);

2009-06-17 16:25:59

by Boaz Harrosh

Subject: Re: [PATCH] driver core: remove unheeded warning about driver methods

On 06/17/2009 06:59 PM, Alan Stern wrote:
> This patch (as1263) removes a warning which has been present for so
> long, and consistently ignored, that it obviously is not doing any
> good. It gets triggered on pretty much every boot by the SCSI disk
> and cdrom drivers. Evidently nobody cares.
>
> Signed-off-by: Alan Stern <[email protected]>
>
> ---
>
> Index: usb-2.6/drivers/base/driver.c
> ===================================================================
> --- usb-2.6.orig/drivers/base/driver.c
> +++ usb-2.6/drivers/base/driver.c
> @@ -225,12 +225,6 @@ int driver_register(struct device_driver
>
> BUG_ON(!drv->bus->p);
>
> - if ((drv->bus->probe && drv->probe) ||
> - (drv->bus->remove && drv->remove) ||
> - (drv->bus->shutdown && drv->shutdown))
> - printk(KERN_WARNING "Driver '%s' needs updating - please use "
> - "bus_type methods\n", drv->name);
> -
> other = driver_find(drv->name, drv->bus);
> if (other) {
> put_driver(other);
>
> --


There was a proper and simple fix for that problem here:
http://www.spinics.net/lists/kernel/msg860289.html

Hannes please re push this patch properly. We want it ;)

Boaz

2009-06-17 17:12:55

by Alan Stern

Subject: Re: [PATCH] driver core: remove unheeded warning about driver methods

On Wed, 17 Jun 2009, Boaz Harrosh wrote:

> There was a proper and simple fix for that problem here:
> http://www.spinics.net/lists/kernel/msg860289.html
>
> Hannes please re push this patch properly. We want it ;)

I have to agree; Hannes's patch is a lot better. Send it in!

Alan Stern