2009-06-17 17:02:12

by Marco Stornelli

[permalink] [raw]
Subject: Re: Re: [PATCH 14/14] Pramfs: XIP Operations

Jared Hulbert wrote:
> > I know. It wasn't my intention to introduce it but as I said in my
> > first patch I've done a porting of this code from 2.6.10 and to
> > remove it I need time to analyze well the code to avoid deadlock and
> > so on. If someone would like to help me I'd really appreciate it.
> > However I see the use of BKL even in other recent "mainlined" fs as
> > ext4, so I preferred to move the porting effort on other areas.
> > However it's the first item on my todo list.

> Why do you need the lock in pram_find_and_alloc_blocks() to begin
> with? Why wouldn't a mutex work?

It's not impossible to use a mutex, but as I said it's inherited from
code written for 2.6.10. This function works as
pram_get_and_update_block works.

Marco