2009-06-20 08:07:04

by Jaswinder Singh Rajput

Subject: [SCSI RESEND] scsi_transport_iscsi.c return -EOVERFLOW for Too many iscsi targets

setting err as -EOVERFLOW for Too many iscsi targets.

Also fixes compiler warning for gcc 4.3.3 and gcc 4.4 :

CC drivers/scsi/scsi_transport_iscsi.o
drivers/scsi/scsi_transport_iscsi.c: In function ‘iscsi_add_session’:
drivers/scsi/scsi_transport_iscsi.c:678: warning: ‘err’ may be used uninitialized in this function

Signed-off-by: Jaswinder Singh Rajput <[email protected]>
---
drivers/scsi/scsi_transport_iscsi.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/scsi/scsi_transport_iscsi.c b/drivers/scsi/scsi_transport_iscsi.c
index 0947954..fdcda7f 100644
--- a/drivers/scsi/scsi_transport_iscsi.c
+++ b/drivers/scsi/scsi_transport_iscsi.c
@@ -693,6 +693,7 @@ int iscsi_add_session(struct iscsi_cls_session *session, unsigned int target_id)
"Too many iscsi targets. Max "
"number of targets is %d.\n",
ISCSI_MAX_TARGET - 1);
+ err = -EOVERFLOW;
goto release_host;
}
}
--
1.6.0.6

2009-06-21 16:37:06

by Mike Christie

Subject: Re: [SCSI RESEND] scsi_transport_iscsi.c return -EOVERFLOW for Too many iscsi targets

On 06/20/2009 02:59 AM, Jaswinder Singh Rajput wrote:
> setting err as -EOVERFLOW for Too many iscsi targets.
>
> Also fixes compiler warning for gcc 4.3.3 and gcc 4.4 :
>
> CC drivers/scsi/scsi_transport_iscsi.o
> drivers/scsi/scsi_transport_iscsi.c: In function ‘iscsi_add_session’:
> drivers/scsi/scsi_transport_iscsi.c:678: warning: ‘err’ may be used uninitialized in this function
>
> Signed-off-by: Jaswinder Singh Rajput<[email protected]>
> ---
> drivers/scsi/scsi_transport_iscsi.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/scsi/scsi_transport_iscsi.c b/drivers/scsi/scsi_transport_iscsi.c
> index 0947954..fdcda7f 100644
> --- a/drivers/scsi/scsi_transport_iscsi.c
> +++ b/drivers/scsi/scsi_transport_iscsi.c
> @@ -693,6 +693,7 @@ int iscsi_add_session(struct iscsi_cls_session *session, unsigned int target_id)
> "Too many iscsi targets. Max "
> "number of targets is %d.\n",
> ISCSI_MAX_TARGET - 1);
> + err = -EOVERFLOW;
> goto release_host;
> }
> }


Acked-by: Mike Christie <[email protected]>