2009-09-14 07:02:33

by Jin Dongming

Subject: [GIT BISECT -next] mem.c: could not login on console of fedora 10

When I build and boot -next on fedora 10, I can not login anymore.
When I input the user name and password, the system does not output
any message and requires user to input the user name and password
again and again.

I find the patch which caused this problem with "GIT BISECT" command.
And the patch is
commit 7c4b7daa1878972ed0137c95f23569124bd6e2b1
"mem_class: use minor as index instead of searching the array".

Though I don't know the real reason why user could not login, I
confirmed the patch I made as following could resolve the problem on
fedora 10.

Signed-off-by: Jin Dongming <[email protected]>
---
drivers/char/mem.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/char/mem.c b/drivers/char/mem.c
index bed3503..0491cdf 100644
--- a/drivers/char/mem.c
+++ b/drivers/char/mem.c
@@ -878,8 +878,8 @@ static const struct memdev {
[ 4] = { "port", &port_fops, NULL },
#endif
[ 5] = { "zero", &zero_fops, &zero_bdi },
- [ 6] = { "full", &full_fops, NULL },
- [ 7] = { "random", &random_fops, NULL },
+ [ 7] = { "full", &full_fops, NULL },
+ [ 8] = { "random", &random_fops, NULL },
[ 9] = { "urandom", &urandom_fops, NULL },
[11] = { "kmsg", &kmsg_fops, NULL },
#ifdef CONFIG_CRASH_DUMP
--
1.6.2.2

2009-09-14 09:07:35

by Jiri Kosina

Subject: Re: [GIT BISECT -next] mem.c: could not login on console of fedora 10

On Mon, 14 Sep 2009, Jin Dongming wrote:

> When I build and boot -next on fedora 10, I can not login anymore.
> When I input the user name and password, the system does not output
> any message and requires user to input the user name and password
> again and again.
>
> I find the patch which caused this problem with "GIT BISECT" command.
> And the patch is
> commit 7c4b7daa1878972ed0137c95f23569124bd6e2b1
> "mem_class: use minor as index instead of searching the array".
>
> Though I don't know the real reason why user could not login, I
> confirmed the patch I made as following could resolve the problem on
> fedora 10.
>
> Signed-off-by: Jin Dongming <[email protected]>
> ---
> drivers/char/mem.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/char/mem.c b/drivers/char/mem.c
> index bed3503..0491cdf 100644
> --- a/drivers/char/mem.c
> +++ b/drivers/char/mem.c
> @@ -878,8 +878,8 @@ static const struct memdev {
> [ 4] = { "port", &port_fops, NULL },
> #endif
> [ 5] = { "zero", &zero_fops, &zero_bdi },
> - [ 6] = { "full", &full_fops, NULL },
> - [ 7] = { "random", &random_fops, NULL },
> + [ 7] = { "full", &full_fops, NULL },
> + [ 8] = { "random", &random_fops, NULL },
> [ 9] = { "urandom", &urandom_fops, NULL },
> [11] = { "kmsg", &kmsg_fops, NULL },
> #ifdef CONFIG_CRASH_DUMP
> --
> 1.6.2.2

I am not entirely sure why I have been CCed on this while the patch author
hasn't :) Adding Kay to CC.

--
Jiri Kosina
SUSE Labs, Novell Inc.

2009-09-14 11:49:54

by Kay Sievers

Subject: Re: [GIT BISECT -next] mem.c: could not login on console of fedora 10

2009/9/14 Jin Dongming <[email protected]>:
> When I build and boot -next on fedora 10, I can not login anymore.
> When I input the user name and password, the system does not output
> any message and requires user to input the user name and password
> again and again.
>
> I find the patch which caused this problem with "GIT BISECT" command.
> And the patch is
>    commit 7c4b7daa1878972ed0137c95f23569124bd6e2b1
>    "mem_class: use minor as index instead of searching the array".
>
> Though I don't know the real reason why user could not login, I
> confirmed the patch I made as following could resolve the problem on
> fedora 10.
>
> Signed-off-by: Jin Dongming <[email protected]>
> ---
>  drivers/char/mem.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/char/mem.c b/drivers/char/mem.c
> index bed3503..0491cdf 100644
> --- a/drivers/char/mem.c
> +++ b/drivers/char/mem.c
> @@ -878,8 +878,8 @@ static const struct memdev {
>        [ 4] = { "port", &port_fops, NULL },
>  #endif
>        [ 5] = { "zero", &zero_fops, &zero_bdi },
> -       [ 6] = { "full", &full_fops, NULL },
> -       [ 7] = { "random", &random_fops, NULL },
> +       [ 7] = { "full", &full_fops, NULL },
> +       [ 8] = { "random", &random_fops, NULL },
>        [ 9] = { "urandom", &urandom_fops, NULL },
>        [11] = { "kmsg", &kmsg_fops, NULL },
>  #ifdef CONFIG_CRASH_DUMP

Yeah, that looks messed up and it seems like the right fix.
Greg, care to merge that into the patch in your tree?

Thanks for the fix and sorry,
Kay