2009-09-26 18:18:36

by Andi Kleen

[permalink] [raw]
Subject: [PATCH] x86: Fix CONFIG_NUMA help message

Noticed recently while looking at this file. The x86 NUMA Kconfig help
entry is not quite correct.

- Core i7 systems are always non NUMA. Refer to multi socket Nehalems instead.
- Replace outdated EM64T term with Intel 64

Signed-off-by: Andi Kleen <[email protected]>
---
arch/x86/Kconfig | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index 384a897..47c81bd 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -1118,8 +1118,9 @@ config NUMA
local memory controller of the CPU and add some more
NUMA awareness to the kernel.

- For 64-bit this is recommended if the system is Intel Core i7
- (or later), AMD Opteron, or EM64T NUMA.
+ For 64-bit this is recommended if the system is Intel Xeon 75xx
+ (Intel Nehalem based multi socket systems), AMD Opteron, or Intel
+ 64 NUMA.

For 32-bit this is only needed on (rare) 32-bit-only platforms
that support NUMA topologies, such as NUMAQ / Summit, or if you
--
1.6.0.2


--
[email protected] -- Speaking for myself only.


2009-09-26 19:55:38

by Brice Goglin

[permalink] [raw]
Subject: Re: [PATCH] x86: Fix CONFIG_NUMA help message

Andi Kleen wrote:
> Noticed recently while looking at this file. The x86 NUMA Kconfig help
> entry is not quite correct.
>
> - Core i7 systems are always non NUMA. Refer to multi socket Nehalems instead.
> - Replace outdated EM64T term with Intel 64
>
> Signed-off-by: Andi Kleen <[email protected]>
> ---
> arch/x86/Kconfig | 5 +++--
> 1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> index 384a897..47c81bd 100644
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -1118,8 +1118,9 @@ config NUMA
> local memory controller of the CPU and add some more
> NUMA awareness to the kernel.
>
> - For 64-bit this is recommended if the system is Intel Core i7
> - (or later), AMD Opteron, or EM64T NUMA.
> + For 64-bit this is recommended if the system is Intel Xeon 75xx
> + (Intel Nehalem based multi socket systems), AMD Opteron, or Intel
> + 64 NUMA.
>
> For 32-bit this is only needed on (rare) 32-bit-only platforms
> that support NUMA topologies, such as NUMAQ / Summit, or if you
>

Why Xeon 75xx and not 55xx ?

Brice