2009-10-03 14:36:55

by Jan Ceuleers

Subject: [PATCH] drivers/video/backlight: memset region size error

>From 61755f56b829f59a40f9d30799651f80a3554104 Mon Sep 17 00:00:00 2001
From: Jan Ceuleers <[email protected]>
Date: Sat, 3 Oct 2009 16:00:36 +0200
Subject: [PATCH] drivers/video/backlight: memset region size error

The size of the region to be memset() should be the size
of the target rather than the size of the pointer to it.

Compile-tested only.

Signed-off-by: Jan Ceuleers <[email protected]>

---
drivers/video/backlight/lcd.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/video/backlight/lcd.c b/drivers/video/backlight/lcd.c
index b644947..a482dd7 100644
--- a/drivers/video/backlight/lcd.c
+++ b/drivers/video/backlight/lcd.c
@@ -56,7 +56,7 @@ static int fb_notifier_callback(struct notifier_block *self,

static int lcd_register_fb(struct lcd_device *ld)
{
- memset(&ld->fb_notif, 0, sizeof(&ld->fb_notif));
+ memset(&ld->fb_notif, 0, sizeof(ld->fb_notif));
ld->fb_notif.notifier_call = fb_notifier_callback;
return fb_register_client(&ld->fb_notif);
}
--
1.5.4.3

2009-10-03 18:19:11

by Richard Purdie

Subject: Re: [PATCH] drivers/video/backlight: memset region size error

On Sat, 2009-10-03 at 16:36 +0200, Jan Ceuleers wrote:
> From 61755f56b829f59a40f9d30799651f80a3554104 Mon Sep 17 00:00:00 2001
> From: Jan Ceuleers <[email protected]>
> Date: Sat, 3 Oct 2009 16:00:36 +0200
> Subject: [PATCH] drivers/video/backlight: memset region size error
>
> The size of the region to be memset() should be the size
> of the target rather than the size of the pointer to it.
>
> Compile-tested only.
>
> Signed-off-by: Jan Ceuleers <[email protected]>

The same patch was posted yesterday by Jean Delvare and I've queued that
but thanks!

Cheers,

Richard
--
Richard Purdie
Intel Open Source Technology Centre