2009-10-07 20:27:09

by Frédéric L. W. Meunier

[permalink] [raw]
Subject: keyboard under X with 2.6.31

My keyboard (ABNT2 PS/2) seems to be broken under X with
2.6.31.2. After less than an hour, it starts acting crazy. The
first time, all leds turned off and I couldn't type anything.
The second time, all leds also turned off, but since it happened
while I was pressing the Backspace key to delete text, it
continued deleting, like if the key was pressed.

In both cases, the mouse (USB) still works and I can exit X,
where the keyboard works. There's nothing in the logs.

No problem with 2.6.30.9. Is it supposed to be a kernel or X bug
?


2009-10-09 02:39:29

by Dmitry Torokhov

[permalink] [raw]
Subject: Re: keyboard under X with 2.6.31

On Wed, Oct 07, 2009 at 05:19:25PM -0300, Fr?d?ric L. W. Meunier wrote:
> My keyboard (ABNT2 PS/2) seems to be broken under X with 2.6.31.2. After
> less than an hour, it starts acting crazy. The first time, all leds
> turned off and I couldn't type anything. The second time, all leds also
> turned off, but since it happened while I was pressing the Backspace key
> to delete text, it continued deleting, like if the key was pressed.
>
> In both cases, the mouse (USB) still works and I can exit X, where the
> keyboard works. There's nothing in the logs.
>
> No problem with 2.6.30.9. Is it supposed to be a kernel or X bug ?

It would be interestig to see if the same keyboard continues to work in
console... if it does then I'd blame X.

--
Dmitry

2009-10-09 02:56:06

by Frédéric L. W. Meunier

[permalink] [raw]
Subject: Re: keyboard under X with 2.6.31

On Thu, 8 Oct 2009, Dmitry Torokhov wrote:

> On Wed, Oct 07, 2009 at 05:19:25PM -0300, Fr?d?ric L. W. Meunier wrote:
>> My keyboard (ABNT2 PS/2) seems to be broken under X with 2.6.31.2. After
>> less than an hour, it starts acting crazy. The first time, all leds
>> turned off and I couldn't type anything. The second time, all leds also
>> turned off, but since it happened while I was pressing the Backspace key
>> to delete text, it continued deleting, like if the key was pressed.
>>
>> In both cases, the mouse (USB) still works and I can exit X, where the
>> keyboard works. There's nothing in the logs.
>>
>> No problem with 2.6.30.9. Is it supposed to be a kernel or X bug ?
>
> It would be interestig to see if the same keyboard continues to work in
> console... if it does then I'd blame X.

I can exit X with the mouse and do anything in the console after
that.

I just reported it to the XOrg mailing-list.

Anyway, I wonder if DRI could mess with the keyboard. I suppose
there were changes (and Radeon related) from 2.6.30 to 2.6.31.
But I can test with it disabled.

2009-10-09 03:20:20

by Justin P. Mattock

[permalink] [raw]
Subject: Re: keyboard under X with 2.6.31

Fr?d?ric L. W. Meunier wrote:
> On Thu, 8 Oct 2009, Dmitry Torokhov wrote:
>
>> On Wed, Oct 07, 2009 at 05:19:25PM -0300, Fr?d?ric L. W. Meunier wrote:
>>> My keyboard (ABNT2 PS/2) seems to be broken under X with 2.6.31.2.
>>> After
>>> less than an hour, it starts acting crazy. The first time, all leds
>>> turned off and I couldn't type anything. The second time, all leds also
>>> turned off, but since it happened while I was pressing the Backspace
>>> key
>>> to delete text, it continued deleting, like if the key was pressed.
>>>
>>> In both cases, the mouse (USB) still works and I can exit X, where the
>>> keyboard works. There's nothing in the logs.
>>>
>>> No problem with 2.6.30.9. Is it supposed to be a kernel or X bug ?
>>
>> It would be interestig to see if the same keyboard continues to work in
>> console... if it does then I'd blame X.
>
> I can exit X with the mouse and do anything in the console after that.
>
> I just reported it to the XOrg mailing-list.
>
> Anyway, I wonder if DRI could mess with the keyboard. I suppose there
> were changes (and Radeon related) from 2.6.30 to 2.6.31. But I can
> test with it disabled.
mess around(maybe) with .xmodmap,
if before X mess with /usr/share/keymap/ *.gz(whatever your using)

Justin P. Mattock

2009-10-10 20:25:49

by Boyan

[permalink] [raw]
Subject: Re: keyboard under X with 2.6.31

On Wed, 7 Oct 2009 17:19:25 -0300, Fr?d?ric L. W. Meunier wrote:
> My keyboard (ABNT2 PS/2) seems to be broken under X with 2.6.31.2.
> After less than an hour, it starts acting crazy. The first time, all
> leds turned off and I couldn't type anything. The second time, all
> leds > also turned off, but since it happened while I was pressing the
> Backspace key to delete text, it continued deleting, like if the key
> was pressed.
>
> In both cases, the mouse (USB) still works and I can exit X, where the
> keyboard works. There's nothing in the logs.
>
> No problem with 2.6.30.9. Is it supposed to be a kernel or X bug ?

Something similar is happening with my keyboard too. With 2.6.31 after
some time the keyboard stops under X on my Fedora 11. I can switch to
text console only after SysRq+R. When go back to X the keyboard is
working, but after some time it stops again.


I can trigger it easily with gthumb quickly changing pictures, but it is
possible with other cpu intensive operations too. To be sure I've tested
with previous X 1.6.3-4 which was from August and I've used it without
problems with 2.6.30 and 2.6.30.3. It was replaced on 18 Sep 2009 by
1.6.4 RC (installed update after 2.6.31). The problem is reproducible on
both of X versions with 2.6.31, 2.6.31.3 and 2.6.32-rc3.

I've bisected this and the result is:

e043e42bdb66885b3ac10d27a01ccb9972e2b0a3 is first bad commit
commit e043e42bdb66885b3ac10d27a01ccb9972e2b0a3
Author: OGAWA Hirofumi <[email protected]>
Date: Wed Jul 29 12:15:56 2009 -0700

pty: avoid forcing 'low_latency' tty flag

We really don't want to mark the pty as a low-latency device,
because as
Alan points out, the ->write method can be called from an IRQ (ppp?),
and that means we can't use ->low_latency=1 as we take mutexes in the
low_latency case.

So rather than using low_latency to force the written data to be pushed
to the ldisc handling at 'write()' time, just make the reader side (or
the poll function) do the flush when it checks whether there is data to
be had.

This also fixes the problem with lost data in an emacs compile buffer
(bugzilla 13815), and we can thus revert the low_latency pty hack
(commit 3a54297478e6578f96fd54bf4daa1751130aca86: "pty: quickfix
for the
pty ENXIO timing problems").

Signed-off-by: OGAWA Hirofumi <[email protected]>
Tested-by: Aneesh Kumar K.V <[email protected]>
[ Modified to do the tty_flush_to_ldisc() inside input_available_p() so
that it triggers for both read and poll() - Linus]
Signed-off-by: Linus Torvalds <[email protected]>

:040000 040000 52e7420b2aa2360632dd965e56b96510619d34e2
5156b59352d1350cb9b4d452581dd84d24d5a541 M drivers
:040000 040000 f0a333b7faa0ce80a57e2ee8536e79a6fe33ac35
b3968b239ac3f64c57f17bb10034b98559f1ffa2 M include


Reverting this patch on top of 2.6.31.3 fixes it for me.

2009-10-11 01:00:51

by Ed Tomlinson

[permalink] [raw]
Subject: Re: keyboard under X with 2.6.31

On Saturday 10 October 2009 16:18:41 Boyan wrote:
> e043e42bdb66885b3ac10d27a01ccb9972e2b0a3

You are not alone with keyboard problems in 31 in X. In my case I blamed a new wireless setup.
I am building with the the above commit reverted.

More to come,
Ed

2009-10-11 06:34:37

by Boyan

[permalink] [raw]
Subject: Re: keyboard under X with 2.6.31

(sending again, sorry about last reply, wrong subject...)
On Sat, 10 Oct 2009 21:00:05 -0400, Ed Tomlinson wrote:
> You are not alone with keyboard problems in 31 in X. In my case I
> blamed a new wireless setup.
> I am building with the the above commit reverted.

Not sure why, but after reverting
e043e42bdb66885b3ac10d27a01ccb9972e2b0a3 (pty: avoid forcing
'low_latency' tty flag) my analog tv tuner stopped working after booting
for the first time. It has TV and FM radio, but only radio worked when
reverted this patch. I saw some EIO errors with strace. Then added again
the patch and on top of it I've added commit:

3a54297478e6578f96fd54bf4daa1751130aca86
pty: quickfix for the pty ENXIO timing problems

Everything was ok.
Today I've tried to reproduce this and reverted both patches. Recompiled
and everything is ok. Not sure what happened yesterday.
So to summarize 2.6.31.3 with reverted commit
e043e42bdb66885b3ac10d27a01ccb9972e2b0a3 (pty: avoid forcing
'low_latency' tty flag) works for me.

2009-10-11 20:40:09

by Frédéric L. W. Meunier

[permalink] [raw]
Subject: Re: keyboard under X with 2.6.31

On Sun, 11 Oct 2009, Boyan wrote:

> (sending again, sorry about last reply, wrong subject...)
> On Sat, 10 Oct 2009 21:00:05 -0400, Ed Tomlinson wrote:
>> You are not alone with keyboard problems in 31 in X. In my case I
>> blamed a new wireless setup.
>> I am building with the the above commit reverted.
>
> Not sure why, but after reverting
> e043e42bdb66885b3ac10d27a01ccb9972e2b0a3 (pty: avoid forcing
> 'low_latency' tty flag) my analog tv tuner stopped working after booting
> for the first time. It has TV and FM radio, but only radio worked when
> reverted this patch. I saw some EIO errors with strace. Then added again
> the patch and on top of it I've added commit:
>
> 3a54297478e6578f96fd54bf4daa1751130aca86
> pty: quickfix for the pty ENXIO timing problems
>
> Everything was ok.
> Today I've tried to reproduce this and reverted both patches. Recompiled
> and everything is ok. Not sure what happened yesterday.
> So to summarize 2.6.31.3 with reverted commit
> e043e42bdb66885b3ac10d27a01ccb9972e2b0a3 (pty: avoid forcing
> 'low_latency' tty flag) works for me.

Reverting the commit also works for me. Thanks.

The direct link, for those not using git:

http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=e043e42bdb66885b3ac10d27a01ccb9972e2b0a3

2009-10-12 19:06:23

by Marcin Slusarz

[permalink] [raw]
Subject: Re: keyboard under X with 2.6.31

Fr?d?ric L. W. Meunier wrote:
> On Sun, 11 Oct 2009, Boyan wrote:
>
>> (sending again, sorry about last reply, wrong subject...)
>> On Sat, 10 Oct 2009 21:00:05 -0400, Ed Tomlinson wrote:
>>> You are not alone with keyboard problems in 31 in X. In my case I
>>> blamed a new wireless setup.
>>> I am building with the the above commit reverted.
>>
>> Not sure why, but after reverting
>> e043e42bdb66885b3ac10d27a01ccb9972e2b0a3 (pty: avoid forcing
>> 'low_latency' tty flag) my analog tv tuner stopped working after booting
>> for the first time. It has TV and FM radio, but only radio worked when
>> reverted this patch. I saw some EIO errors with strace. Then added again
>> the patch and on top of it I've added commit:
>>
>> 3a54297478e6578f96fd54bf4daa1751130aca86
>> pty: quickfix for the pty ENXIO timing problems
>>
>> Everything was ok.
>> Today I've tried to reproduce this and reverted both patches. Recompiled
>> and everything is ok. Not sure what happened yesterday.
>> So to summarize 2.6.31.3 with reverted commit
>> e043e42bdb66885b3ac10d27a01ccb9972e2b0a3 (pty: avoid forcing
>> 'low_latency' tty flag) works for me.
>
> Reverting the commit also works for me. Thanks.
>
> The direct link, for those not using git:
>
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=e043e42bdb66885b3ac10d27a01ccb9972e2b0a3

CC'ing Greg K-H

2009-10-15 18:45:45

by Greg KH

[permalink] [raw]
Subject: Re: keyboard under X with 2.6.31

On Mon, Oct 12, 2009 at 09:05:41PM +0200, Marcin Slusarz wrote:
> Fr?d?ric L. W. Meunier wrote:
> > On Sun, 11 Oct 2009, Boyan wrote:
> >
> >> (sending again, sorry about last reply, wrong subject...)
> >> On Sat, 10 Oct 2009 21:00:05 -0400, Ed Tomlinson wrote:
> >>> You are not alone with keyboard problems in 31 in X. In my case I
> >>> blamed a new wireless setup.
> >>> I am building with the the above commit reverted.
> >>
> >> Not sure why, but after reverting
> >> e043e42bdb66885b3ac10d27a01ccb9972e2b0a3 (pty: avoid forcing
> >> 'low_latency' tty flag) my analog tv tuner stopped working after booting
> >> for the first time. It has TV and FM radio, but only radio worked when
> >> reverted this patch. I saw some EIO errors with strace. Then added again
> >> the patch and on top of it I've added commit:
> >>
> >> 3a54297478e6578f96fd54bf4daa1751130aca86
> >> pty: quickfix for the pty ENXIO timing problems
> >>
> >> Everything was ok.
> >> Today I've tried to reproduce this and reverted both patches. Recompiled
> >> and everything is ok. Not sure what happened yesterday.
> >> So to summarize 2.6.31.3 with reverted commit
> >> e043e42bdb66885b3ac10d27a01ccb9972e2b0a3 (pty: avoid forcing
> >> 'low_latency' tty flag) works for me.
> >
> > Reverting the commit also works for me. Thanks.
> >
> > The direct link, for those not using git:
> >
> > http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=e043e42bdb66885b3ac10d27a01ccb9972e2b0a3
>
> CC'ing Greg K-H

I've now queued up 3a54297478e6578f96fd54bf4daa1751130aca86 for the next
.31-stable release.

thanks for letting me know.

greg k-h