2009-10-26 21:22:28

by Roel Kluin

Subject: [PATCH] icst307: Add missing increment

Without this increment the loop can only break if it does in the
first iteration.

Signed-off-by: Roel Kluin <[email protected]>
---
diff --git a/arch/arm/common/icst307.c b/arch/arm/common/icst307.c
index 6d094c1..b255fbf 100644
--- a/arch/arm/common/icst307.c
+++ b/arch/arm/common/icst307.c
@@ -55,7 +55,7 @@ icst307_khz_to_vco(const struct icst307_params *p, unsigned long freq)
*/
if (f > 6000 && f <= p->vco_max)
break;
- } while (i < ARRAY_SIZE(idx2s));
+ } while (++i < ARRAY_SIZE(idx2s));

if (i >= ARRAY_SIZE(idx2s))
return vco;
@@ -117,7 +117,7 @@ icst307_ps_to_vco(const struct icst307_params *p, unsigned long period)
*/
if (f >= ps && f < 1000000000UL / 6000 + 1)
break;
- } while (i < ARRAY_SIZE(idx2s));
+ } while (++i < ARRAY_SIZE(idx2s));

if (i >= ARRAY_SIZE(idx2s))
return vco;

2009-10-26 21:35:58

by Roel Kluin

Subject: [PATCH] icst525: Add missing increment

Without this increment the loop can only break if it does in the
first iteration.

Signed-off-by: Roel Kluin <[email protected]>
---
arch/arm/common/icst525.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

Same issue, different file.

diff --git a/arch/arm/common/icst525.c b/arch/arm/common/icst525.c
index 3d377c5..0aef96a 100644
--- a/arch/arm/common/icst525.c
+++ b/arch/arm/common/icst525.c
@@ -53,7 +53,7 @@ icst525_khz_to_vco(const struct icst525_params *p, unsigned long freq)
*/
if (f > 10000 && f <= p->vco_max)
break;
- } while (i < ARRAY_SIZE(idx2s));
+ } while (++i < ARRAY_SIZE(idx2s));

if (i >= ARRAY_SIZE(idx2s))
return vco;
@@ -116,7 +116,7 @@ icst525_ps_to_vco(const struct icst525_params *p, unsigned long period)
*/
if (f >= ps && f < 100000)
break;
- } while (i < ARRAY_SIZE(idx2s));
+ } while (++i < ARRAY_SIZE(idx2s));

if (i >= ARRAY_SIZE(idx2s))
return vco;

2009-10-27 19:38:59

by Russell King - ARM Linux

Subject: Re: [PATCH] icst307: Add missing increment

On Mon, Oct 26, 2009 at 10:33:04PM +0100, Roel Kluin wrote:
> Without this increment the loop can only break if it does in the
> first iteration.

Ok.

2009-10-27 19:39:05

by Russell King - ARM Linux

Subject: Re: [PATCH] icst525: Add missing increment

On Mon, Oct 26, 2009 at 10:46:35PM +0100, Roel Kluin wrote:
> Without this increment the loop can only break if it does in the
> first iteration.

Ok.