2009-11-11 20:35:07

by Roel Kluin

Subject: [PATCH] mtd: error return -EIO instead of EIO

Return a negative error value instead of a positive

Signed-off-by: Roel Kluin <[email protected]>
---
drivers/mtd/maps/physmap.c | 2 +-
drivers/mtd/maps/vmu-flash.c | 2 +-
drivers/mtd/nand/atmel_nand.c | 4 ++--
3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/mtd/maps/physmap.c b/drivers/mtd/maps/physmap.c
index 380648e..a5a72b2 100644
--- a/drivers/mtd/maps/physmap.c
+++ b/drivers/mtd/maps/physmap.c
@@ -130,7 +130,7 @@ static int physmap_flash_probe(struct platform_device *dev)
info->map[i].size);
if (info->map[i].virt == NULL) {
dev_err(&dev->dev, "Failed to ioremap flash region\n");
- err = EIO;
+ err = -EIO;
goto err_out;
}

diff --git a/drivers/mtd/maps/vmu-flash.c b/drivers/mtd/maps/vmu-flash.c
index 1f73297..b02db6f 100644
--- a/drivers/mtd/maps/vmu-flash.c
+++ b/drivers/mtd/maps/vmu-flash.c
@@ -621,7 +621,7 @@ static int __devinit vmu_connect(struct maple_device *mdev)

card = kmalloc(sizeof(struct memcard), GFP_KERNEL);
if (!card) {
- error = ENOMEM;
+ error = -ENOMEM;
goto fail_nomem;
}

diff --git a/drivers/mtd/nand/atmel_nand.c b/drivers/mtd/nand/atmel_nand.c
index f8e9975..e4aeeed 100644
--- a/drivers/mtd/nand/atmel_nand.c
+++ b/drivers/mtd/nand/atmel_nand.c
@@ -464,7 +464,7 @@ static int __init atmel_nand_probe(struct platform_device *pdev)
if (host->board->det_pin) {
if (gpio_get_value(host->board->det_pin)) {
printk(KERN_INFO "No SmartMedia card inserted.\n");
- res = ENXIO;
+ res = -ENXIO;
goto err_no_card;
}
}
@@ -535,7 +535,7 @@ static int __init atmel_nand_probe(struct platform_device *pdev)

if ((!partitions) || (num_partitions == 0)) {
printk(KERN_ERR "atmel_nand: No partitions defined, or unsupported device.\n");
- res = ENXIO;
+ res = -ENXIO;
goto err_no_partitions;
}

2009-11-13 08:28:50

by Artem Bityutskiy

Subject: Re: [PATCH] mtd: error return -EIO instead of EIO

On Wed, 2009-11-11 at 21:47 +0100, Roel Kluin wrote:
> Return a negative error value instead of a positive
>
> Signed-off-by: Roel Kluin <[email protected]>
> ---
> drivers/mtd/maps/physmap.c | 2 +-
> drivers/mtd/maps/vmu-flash.c | 2 +-
> drivers/mtd/nand/atmel_nand.c | 4 ++--
> 3 files changed, 4 insertions(+), 4 deletions(-)

Taken to my l2-mtd-2.6.git tree, thanks.

--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)