2009-11-11 22:20:59

by Roel Kluin

Subject: [PATCH] netfilter: Should xt_osf_remove_callback() return negative on errors?

Return a negative error value

Signed-off-by: Roel Kluin <[email protected]>
---
net/netfilter/xt_osf.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

It seems strange that an error return can be positive or
negative, is this maybe required?

diff --git a/net/netfilter/xt_osf.c b/net/netfilter/xt_osf.c
index 63e1905..4d1a41b 100644
--- a/net/netfilter/xt_osf.c
+++ b/net/netfilter/xt_osf.c
@@ -118,7 +118,7 @@ static int xt_osf_remove_callback(struct sock *ctnl, struct sk_buff *skb,
{
struct xt_osf_user_finger *f;
struct xt_osf_finger *sf;
- int err = ENOENT;
+ int err = -ENOENT;

if (!osf_attrs[OSF_ATTR_FINGER])
return -EINVAL;

2009-11-13 08:32:34

by Patrick McHardy

Subject: Re: [PATCH] netfilter: Should xt_osf_remove_callback() return negative on errors?

Roel Kluin wrote:
> Return a negative error value

Applied, thanks.