2009-11-10 23:58:13

by Krzysztof Halasa

Subject: ATA: Make CS5536 PATA driver use 32-bit BM DMA template instead of 16-bit.

Tested on IXP425 + CS5536.

Signed-off-by: Krzysztof Hałasa <[email protected]>

diff --git a/drivers/ata/pata_cs5536.c b/drivers/ata/pata_cs5536.c
index 88a7933..0898213 100644
--- a/drivers/ata/pata_cs5536.c
+++ b/drivers/ata/pata_cs5536.c
@@ -232,7 +232,7 @@ static struct scsi_host_template cs5536_sht = {
};

static struct ata_port_operations cs5536_port_ops = {
- .inherits = &ata_bmdma_port_ops,
+ .inherits = &ata_bmdma32_port_ops,
.cable_detect = cs5536_cable_detect,
.set_piomode = cs5536_set_piomode,
.set_dmamode = cs5536_set_dmamode,

--
Krzysztof Halasa

2009-11-11 00:08:11

by Lennart Sorensen

Subject: Re: ATA: Make CS5536 PATA driver use 32-bit BM DMA template instead of 16-bit.

On Wed, Nov 11, 2009 at 12:58:16AM +0100, Krzysztof Halasa wrote:
> Tested on IXP425 + CS5536.

Well I guess we will find out if it works on the Geode LX + CS5536 and
loongson + CS5536 sometime. I don't know why it wouldn't work.

> Signed-off-by: Krzysztof Hałasa <[email protected]>
>
> diff --git a/drivers/ata/pata_cs5536.c b/drivers/ata/pata_cs5536.c
> index 88a7933..0898213 100644
> --- a/drivers/ata/pata_cs5536.c
> +++ b/drivers/ata/pata_cs5536.c
> @@ -232,7 +232,7 @@ static struct scsi_host_template cs5536_sht = {
> };
>
> static struct ata_port_operations cs5536_port_ops = {
> - .inherits = &ata_bmdma_port_ops,
> + .inherits = &ata_bmdma32_port_ops,
> .cable_detect = cs5536_cable_detect,
> .set_piomode = cs5536_set_piomode,
> .set_dmamode = cs5536_set_dmamode,

--
Len Sorensen

2009-11-17 03:18:01

by Jeff Garzik

Subject: Re: ATA: Make CS5536 PATA driver use 32-bit BM DMA template instead of 16-bit.

On 11/10/2009 06:58 PM, Krzysztof Halasa wrote:
> Tested on IXP425 + CS5536.
>
> Signed-off-by: Krzysztof Hałasa<[email protected]>
>
> diff --git a/drivers/ata/pata_cs5536.c b/drivers/ata/pata_cs5536.c
> index 88a7933..0898213 100644
> --- a/drivers/ata/pata_cs5536.c
> +++ b/drivers/ata/pata_cs5536.c
> @@ -232,7 +232,7 @@ static struct scsi_host_template cs5536_sht = {
> };
>
> static struct ata_port_operations cs5536_port_ops = {
> - .inherits =&ata_bmdma_port_ops,
> + .inherits =&ata_bmdma32_port_ops,
> .cable_detect = cs5536_cable_detect,
> .set_piomode = cs5536_set_piomode,
> .set_dmamode = cs5536_set_dmamode,

applied