2009-10-09 09:16:49

by Nicolas Ferre

Subject: [PATCH TRIVIAL] atmel_lcdfb.c: Fix sinfo->irqbase from %lu to %d in dev_info().

From: Claudio Scordino <[email protected]>

This patch fixes a type mismatch when calling dev_info() in the
atmel_lcdfb.c driver.

Signed-off-by: Claudio Scordino <[email protected]>
Signed-off-by: Nicolas Ferre <[email protected]>
---
drivers/video/atmel_lcdfb.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/video/atmel_lcdfb.c b/drivers/video/atmel_lcdfb.c
index 2830ffd..317afab 100644
--- a/drivers/video/atmel_lcdfb.c
+++ b/drivers/video/atmel_lcdfb.c
@@ -959,7 +959,7 @@ static int __init atmel_lcdfb_probe(struct platform_device *pdev)
if (sinfo->atmel_lcdfb_power_control)
sinfo->atmel_lcdfb_power_control(1);

- dev_info(dev, "fb%d: Atmel LCDC at 0x%08lx (mapped at %p), irq %lu\n",
+ dev_info(dev, "fb%d: Atmel LCDC at 0x%08lx (mapped at %p), irq %d\n",
info->node, info->fix.mmio_start, sinfo->mmio, sinfo->irq_base);

return 0;
--
1.5.6.5

2009-10-09 15:31:42

by Jiri Kosina

Subject: Re: [PATCH TRIVIAL] atmel_lcdfb.c: Fix sinfo->irqbase from %lu to %d in dev_info().

On Fri, 9 Oct 2009, Nicolas Ferre wrote:

> From: Claudio Scordino <[email protected]>
>
> This patch fixes a type mismatch when calling dev_info() in the
> atmel_lcdfb.c driver.
>
> Signed-off-by: Claudio Scordino <[email protected]>
> Signed-off-by: Nicolas Ferre <[email protected]>
> ---
> drivers/video/atmel_lcdfb.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/video/atmel_lcdfb.c b/drivers/video/atmel_lcdfb.c
> index 2830ffd..317afab 100644
> --- a/drivers/video/atmel_lcdfb.c
> +++ b/drivers/video/atmel_lcdfb.c
> @@ -959,7 +959,7 @@ static int __init atmel_lcdfb_probe(struct platform_device *pdev)
> if (sinfo->atmel_lcdfb_power_control)
> sinfo->atmel_lcdfb_power_control(1);
>
> - dev_info(dev, "fb%d: Atmel LCDC at 0x%08lx (mapped at %p), irq %lu\n",
> + dev_info(dev, "fb%d: Atmel LCDC at 0x%08lx (mapped at %p), irq %d\n",
> info->node, info->fix.mmio_start, sinfo->mmio, sinfo->irq_base);
>
> return 0;

Applied, thanks.

--
Jiri Kosina
SUSE Labs, Novell Inc.

2009-11-23 08:30:25

by Claudio Scordino

Subject: Re: [PATCH TRIVIAL] atmel_lcdfb.c: Fix sinfo->irqbase from %lu to %d in dev_info().

Jiri Kosina ha scritto:
> On Fri, 9 Oct 2009, Nicolas Ferre wrote:
>
>> From: Claudio Scordino <[email protected]>
>>
>> This patch fixes a type mismatch when calling dev_info() in the
>> atmel_lcdfb.c driver.
>>
>> Signed-off-by: Claudio Scordino <[email protected]>
>> Signed-off-by: Nicolas Ferre <[email protected]>
>> ---
>> drivers/video/atmel_lcdfb.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/video/atmel_lcdfb.c b/drivers/video/atmel_lcdfb.c
>> index 2830ffd..317afab 100644
>> --- a/drivers/video/atmel_lcdfb.c
>> +++ b/drivers/video/atmel_lcdfb.c
>> @@ -959,7 +959,7 @@ static int __init atmel_lcdfb_probe(struct platform_device *pdev)
>> if (sinfo->atmel_lcdfb_power_control)
>> sinfo->atmel_lcdfb_power_control(1);
>>
>> - dev_info(dev, "fb%d: Atmel LCDC at 0x%08lx (mapped at %p), irq %lu\n",
>> + dev_info(dev, "fb%d: Atmel LCDC at 0x%08lx (mapped at %p), irq %d\n",
>> info->node, info->fix.mmio_start, sinfo->mmio, sinfo->irq_base);
>>
>> return 0;
>
> Applied, thanks.
>

Hi,

may I ask you the current status of this patch ? I noticed that it
has not been merged, yet.

Do we have any idea when it will be done ?

Since it is a trivial fix, I think it should be merged before the
release of v2.6.32 (i.e., waiting the next merge window does not make
much sense for such a trivial fix...).

Many thanks,

Claudio

2009-11-23 09:25:11

by Jiri Kosina

Subject: Re: [PATCH TRIVIAL] atmel_lcdfb.c: Fix sinfo->irqbase from %lu to %d in dev_info().

On Mon, 23 Nov 2009, Claudio Scordino wrote:

> may I ask you the current status of this patch ? I noticed that it
> has not been merged, yet.
>
> Do we have any idea when it will be done ?
>
> Since it is a trivial fix, I think it should be merged before the
> release of v2.6.32 (i.e., waiting the next merge window does not make
> much sense for such a trivial fix...).

I usually don't send pull requests for trivial queue to Linus more than
once per release cycle.

--
Jiri Kosina
SUSE Labs, Novell Inc.

2009-11-23 10:03:57

by Claudio Scordino

Subject: Re: [PATCH TRIVIAL] atmel_lcdfb.c: Fix sinfo->irqbase from %lu to %d in dev_info().

Jiri Kosina ha scritto:
> On Mon, 23 Nov 2009, Claudio Scordino wrote:
>
>
>> may I ask you the current status of this patch ? I noticed that it
>> has not been merged, yet.
>>
>> Do we have any idea when it will be done ?
>>
>> Since it is a trivial fix, I think it should be merged before the
>> release of v2.6.32 (i.e., waiting the next merge window does not make
>> much sense for such a trivial fix...).
>>
>
> I usually don't send pull requests for trivial queue to Linus more than
> once per release cycle.
>
Oh, I see. Sorry for the noise, then.

Many thanks again,

Claudio