2009-11-30 11:10:30

by helight

Subject: Subject: [PATCH 2/2] fix a Section mismatch in arch/x86/pci/mmconfig-shared.c and include/linux/sfi_acpi.h

acpi_sfi_table_parse() should be __init. tested on x86 system!

warning msg:

WARNING: vmlinux.o(.text+0x322e69): Section mismatch in reference from
the function acpi_sfi_table_parse() to the function
.init.text:acpi_table_parse()
The function acpi_sfi_table_parse() references
the function __init acpi_table_parse().
This is often because acpi_sfi_table_parse lacks a __init
annotation or the annotation of acpi_table_parse is wrong.


Signed-off-by: ZhenwenXu <[email protected]>
---
include/linux/sfi_acpi.h | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/linux/sfi_acpi.h b/include/linux/sfi_acpi.h
index c4a5a8c..631af63 100644
--- a/include/linux/sfi_acpi.h
+++ b/include/linux/sfi_acpi.h
@@ -66,7 +66,7 @@ extern int sfi_acpi_table_parse(char *signature, char
*oem_id,
char *oem_table_id,
int (*handler)(struct acpi_table_header *));

-static inline int acpi_sfi_table_parse(char *signature,
+static inline int __init acpi_sfi_table_parse(char *signature,
int (*handler)(struct acpi_table_header *))
{
if (!acpi_table_parse(signature, handler))
@@ -83,7 +83,7 @@ static inline int sfi_acpi_table_parse(char
*signature, char *oem_id,
return -1;
}

-static inline int acpi_sfi_table_parse(char *signature,
+static inline int __init acpi_sfi_table_parse(char *signature,
int (*handler)(struct acpi_table_header *))
{
return acpi_table_parse(signature, handler);
--
1.6.5.3

--
---------------------------------
Zhenwen Xu - Open and Free
Home Page: http://zhwen.org

2009-11-30 19:19:40

by H. Peter Anvin

Subject: Re: Subject: [PATCH 2/2] fix a Section mismatch in arch/x86/pci/mmconfig-shared.c and include/linux/sfi_acpi.h

Hi Len,

Do you want to take this one or should I?

-hpa


On 11/30/2009 02:38 AM, helight wrote:
> acpi_sfi_table_parse() should be __init. tested on x86 system!

2009-12-01 01:34:25

by helight

Subject: Re: Subject: [PATCH 2/2] fix a Section mismatch in arch/x86/pci/mmconfig-shared.c and include/linux/sfi_acpi.h

H. Peter Anvin wrote:
> Hi Len,
>
> Do you want to take this one or should I?
>
ooh! both ok！thing is that we fix the problem!
> -hpa
>
>
> On 11/30/2009 02:38 AM, helight wrote:
>
>> acpi_sfi_table_parse() should be __init. tested on x86 system!
>>
>
>


--
---------------------------------
Zhenwen Xu - Open and Free
Home Page: http://zhwen.org

2009-12-01 01:08:10

by helight.xu

Subject: Re: Subject: [PATCH 2/2] fix a Section mismatch in arch/x86/pci/mmconfig-shared.c and include/linux/sfi_acpi.h

H. Peter Anvin wrote:
> Hi Len,
>
> Do you want to take this one or should I?
>
ooh! both ok！thing is that we fix the problem!
> -hpa
>
>
> On 11/30/2009 02:38 AM, helight wrote:
>
>> acpi_sfi_table_parse() should be __init. tested on x86 system!
>>
>
>


--
---------------------------------
Zhenwen Xu - Open and Free
Home Page: http://zhwen.org