2009-12-07 13:17:29

by Roel Kluin

Subject: [PATCH] dasd: PTR_ERR return of wrong pointer in dasd_alias_make_device_known_to_lcu()

Return the PTR_ERR of the correct pointer.

Signed-off-by: Roel Kluin <[email protected]>
---
drivers/s390/block/dasd_alias.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

Unless I am mistaken?

diff --git a/drivers/s390/block/dasd_alias.c b/drivers/s390/block/dasd_alias.c
index 70a008c..fa37148 100644
--- a/drivers/s390/block/dasd_alias.c
+++ b/drivers/s390/block/dasd_alias.c
@@ -217,7 +217,7 @@ int dasd_alias_make_device_known_to_lcu(struct dasd_device *device)
spin_unlock_irqrestore(&aliastree.lock, flags);
newlcu = _allocate_lcu(uid);
if (IS_ERR(newlcu))
- return PTR_ERR(lcu);
+ return PTR_ERR(newlcu);
spin_lock_irqsave(&aliastree.lock, flags);
lcu = _find_lcu(server, uid);
if (!lcu) {

2009-12-07 13:22:06

by Martin Schwidefsky

Subject: Re: [PATCH] dasd: PTR_ERR return of wrong pointer in dasd_alias_make_device_known_to_lcu()

On Mon, 07 Dec 2009 14:18:40 +0100
Roel Kluin <[email protected]> wrote:

> Return the PTR_ERR of the correct pointer.
>
> Signed-off-by: Roel Kluin <[email protected]>
> ---
> drivers/s390/block/dasd_alias.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> Unless I am mistaken?
>
> diff --git a/drivers/s390/block/dasd_alias.c b/drivers/s390/block/dasd_alias.c
> index 70a008c..fa37148 100644
> --- a/drivers/s390/block/dasd_alias.c
> +++ b/drivers/s390/block/dasd_alias.c
> @@ -217,7 +217,7 @@ int dasd_alias_make_device_known_to_lcu(struct dasd_device *device)
> spin_unlock_irqrestore(&aliastree.lock, flags);
> newlcu = _allocate_lcu(uid);
> if (IS_ERR(newlcu))
> - return PTR_ERR(lcu);
> + return PTR_ERR(newlcu);
> spin_lock_irqsave(&aliastree.lock, flags);
> lcu = _find_lcu(server, uid);
> if (!lcu) {

You are not mistaken. I'll add the patch to the queue. Thanks.

--
blue skies,
Martin.

"Reality continues to ruin my life." - Calvin.