2009-12-10 06:01:55

by Gui, Jianfeng/归 剑峰

Subject: [PATCH] cfq: Remove wait_request flag when idle time is being deleted

Hi Jens,

I post this patch a few month ago, it seems to get missing, repost again.

Remove wait_request flag when idle time is being deleted.

Signed-off-by: Gui Jianfeng <[email protected]>
---
block/cfq-iosched.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/block/cfq-iosched.c b/block/cfq-iosched.c
index 69ecee7..96f59ae 100644
--- a/block/cfq-iosched.c
+++ b/block/cfq-iosched.c
@@ -3202,6 +3202,7 @@ cfq_rq_enqueued(struct cfq_data *cfqd, struct cfq_queue *cfqq,
if (blk_rq_bytes(rq) > PAGE_CACHE_SIZE ||
cfqd->busy_queues > 1) {
del_timer(&cfqd->idle_slice_timer);
+ cfq_clear_cfqq_wait_request(cfqq);
__blk_run_queue(cfqd->queue);
} else
cfq_mark_cfqq_must_dispatch(cfqq);
--
1.5.4.rc3

2009-12-10 08:38:42

by Jens Axboe

Subject: Re: [PATCH] cfq: Remove wait_request flag when idle time is being deleted

On Thu, Dec 10 2009, Gui Jianfeng wrote:
> Hi Jens,
>
> I post this patch a few month ago, it seems to get missing, repost again.
>
> Remove wait_request flag when idle time is being deleted.
>
> Signed-off-by: Gui Jianfeng <[email protected]>
> ---
> block/cfq-iosched.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/block/cfq-iosched.c b/block/cfq-iosched.c
> index 69ecee7..96f59ae 100644
> --- a/block/cfq-iosched.c
> +++ b/block/cfq-iosched.c
> @@ -3202,6 +3202,7 @@ cfq_rq_enqueued(struct cfq_data *cfqd, struct cfq_queue *cfqq,
> if (blk_rq_bytes(rq) > PAGE_CACHE_SIZE ||
> cfqd->busy_queues > 1) {
> del_timer(&cfqd->idle_slice_timer);
> + cfq_clear_cfqq_wait_request(cfqq);
> __blk_run_queue(cfqd->queue);
> } else
> cfq_mark_cfqq_must_dispatch(cfqq);

Hmm weird, I think it may have gone missing in a badly done merge. I'll
add it, thanks.

--
Jens Axboe