2009-12-13 22:49:10

by Justin P. Mattock

[permalink] [raw]
Subject: Fix-a-typo-in-battery.c

Fix a typo in a comment in
drivers/acpi/battery.c

drivers/acpi/battery.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)


2009-12-13 22:49:21

by Justin P. Mattock

[permalink] [raw]
Subject: [PATCH] Fix a typo in drivers/acpi/battery.c

Signed-off-by: Justin P. Mattock <[email protected]>
---
drivers/acpi/battery.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/acpi/battery.c b/drivers/acpi/battery.c
index 3f4602b..cada73f 100644
--- a/drivers/acpi/battery.c
+++ b/drivers/acpi/battery.c
@@ -831,7 +831,7 @@ static void acpi_battery_notify(struct acpi_device *device, u32 event)
dev_name(&device->dev), event,
acpi_battery_present(battery));
#ifdef CONFIG_ACPI_SYSFS_POWER
- /* acpi_batter_update could remove power_supply object */
+ /* acpi_battery_update could remove power_supply object */
if (battery->bat.dev)
kobject_uevent(&battery->bat.dev->kobj, KOBJ_CHANGE);
#endif
--
1.6.5.5

2009-12-13 23:15:41

by Randy Dunlap

[permalink] [raw]
Subject: Re: [PATCH] Fix a typo in drivers/acpi/battery.c

On Sun, 13 Dec 2009 14:48:56 -0800 Justin P. Mattock wrote:

> Signed-off-by: Justin P. Mattock <[email protected]>
> ---
> drivers/acpi/battery.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/acpi/battery.c b/drivers/acpi/battery.c
> index 3f4602b..cada73f 100644
> --- a/drivers/acpi/battery.c
> +++ b/drivers/acpi/battery.c
> @@ -831,7 +831,7 @@ static void acpi_battery_notify(struct acpi_device *device, u32 event)
> dev_name(&device->dev), event,
> acpi_battery_present(battery));
> #ifdef CONFIG_ACPI_SYSFS_POWER
> - /* acpi_batter_update could remove power_supply object */
> + /* acpi_battery_update could remove power_supply object */
> if (battery->bat.dev)
> kobject_uevent(&battery->bat.dev->kobj, KOBJ_CHANGE);
> #endif
> --

Hi,

You don't need an intro patch email and then the patch email
for such a simple patch.

Also, please note (from "MAINTAINERS" or from scripts/get_maintainer.pl)
that acpi patches go to [email protected] .

---
~Randy

2009-12-14 00:28:24

by Justin P. Mattock

[permalink] [raw]
Subject: Re: [PATCH] Fix a typo in drivers/acpi/battery.c

On 12/13/09 15:15, Randy Dunlap wrote:
> On Sun, 13 Dec 2009 14:48:56 -0800 Justin P. Mattock wrote:
>
>> Signed-off-by: Justin P. Mattock<[email protected]>
>> ---
>> drivers/acpi/battery.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/acpi/battery.c b/drivers/acpi/battery.c
>> index 3f4602b..cada73f 100644
>> --- a/drivers/acpi/battery.c
>> +++ b/drivers/acpi/battery.c
>> @@ -831,7 +831,7 @@ static void acpi_battery_notify(struct acpi_device *device, u32 event)
>> dev_name(&device->dev), event,
>> acpi_battery_present(battery));
>> #ifdef CONFIG_ACPI_SYSFS_POWER
>> - /* acpi_batter_update could remove power_supply object */
>> + /* acpi_battery_update could remove power_supply object */
>> if (battery->bat.dev)
>> kobject_uevent(&battery->bat.dev->kobj, KOBJ_CHANGE);
>> #endif
>> --
>
> Hi,
>
> You don't need an intro patch email and then the patch email
> for such a simple patch.
>
> Also, please note (from "MAINTAINERS" or from scripts/get_maintainer.pl)
> that acpi patches go to [email protected] .
>
> ---
> ~Randy
>

So should I resend this to acpi then, or just
take note of this the next time?

Justin P. Mattock

2009-12-14 01:21:26

by Randy Dunlap

[permalink] [raw]
Subject: Re: [PATCH] Fix a typo in drivers/acpi/battery.c

On Sun, 13 Dec 2009 16:23:18 -0800 Justin P. Mattock wrote:

> On 12/13/09 15:15, Randy Dunlap wrote:
> > On Sun, 13 Dec 2009 14:48:56 -0800 Justin P. Mattock wrote:
> >
> >> Signed-off-by: Justin P. Mattock<[email protected]>
> >> ---
> >> drivers/acpi/battery.c | 2 +-
> >> 1 files changed, 1 insertions(+), 1 deletions(-)
> >>
> >> diff --git a/drivers/acpi/battery.c b/drivers/acpi/battery.c
> >> index 3f4602b..cada73f 100644
> >> --- a/drivers/acpi/battery.c
> >> +++ b/drivers/acpi/battery.c
> >> @@ -831,7 +831,7 @@ static void acpi_battery_notify(struct acpi_device *device, u32 event)
> >> dev_name(&device->dev), event,
> >> acpi_battery_present(battery));
> >> #ifdef CONFIG_ACPI_SYSFS_POWER
> >> - /* acpi_batter_update could remove power_supply object */
> >> + /* acpi_battery_update could remove power_supply object */
> >> if (battery->bat.dev)
> >> kobject_uevent(&battery->bat.dev->kobj, KOBJ_CHANGE);
> >> #endif
> >> --
> >
> > Hi,
> >
> > You don't need an intro patch email and then the patch email
> > for such a simple patch.
> >
> > Also, please note (from "MAINTAINERS" or from scripts/get_maintainer.pl)
> > that acpi patches go to [email protected] .
> >
> > ---
> > ~Randy
> >
>
> So should I resend this to acpi then, or just
> take note of this the next time?

I'd say resend to linux-acpi and cc: the acpi maintainer.

---
~Randy

2009-12-14 02:35:14

by Justin P. Mattock

[permalink] [raw]
Subject: Re: [PATCH] Fix a typo in drivers/acpi/battery.c

On 12/13/09 17:21, Randy Dunlap wrote:
> On Sun, 13 Dec 2009 16:23:18 -0800 Justin P. Mattock wrote:
>
>> On 12/13/09 15:15, Randy Dunlap wrote:
>>> On Sun, 13 Dec 2009 14:48:56 -0800 Justin P. Mattock wrote:
>>>
>>>> Signed-off-by: Justin P. Mattock<[email protected]>
>>>> ---
>>>> drivers/acpi/battery.c | 2 +-
>>>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>>>
>>>> diff --git a/drivers/acpi/battery.c b/drivers/acpi/battery.c
>>>> index 3f4602b..cada73f 100644
>>>> --- a/drivers/acpi/battery.c
>>>> +++ b/drivers/acpi/battery.c
>>>> @@ -831,7 +831,7 @@ static void acpi_battery_notify(struct acpi_device *device, u32 event)
>>>> dev_name(&device->dev), event,
>>>> acpi_battery_present(battery));
>>>> #ifdef CONFIG_ACPI_SYSFS_POWER
>>>> - /* acpi_batter_update could remove power_supply object */
>>>> + /* acpi_battery_update could remove power_supply object */
>>>> if (battery->bat.dev)
>>>> kobject_uevent(&battery->bat.dev->kobj, KOBJ_CHANGE);
>>>> #endif
>>>> --
>>>
>>> Hi,
>>>
>>> You don't need an intro patch email and then the patch email
>>> for such a simple patch.
>>>
>>> Also, please note (from "MAINTAINERS" or from scripts/get_maintainer.pl)
>>> that acpi patches go to [email protected] .
>>>
>>> ---
>>> ~Randy
>>>
>>
>> So should I resend this to acpi then, or just
>> take note of this the next time?
>
> I'd say resend to linux-acpi and cc: the acpi maintainer.
>
> ---
> ~Randy
>

there you have it.
cc'd len brown
(not sure who the acpi maintainers are)

Justin P. Mattock