2009-12-16 22:35:27

by Tony Lindgren

[permalink] [raw]
Subject: [GIT PULL] omap build fixes

Hi Linus,

Please pull omap build fixes from:

git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap-2.6.git omap-fixes-for-linus

In addition to the three build fixes, there's also a suspend fix
for omap serial init.

Regards,

Tony


The following changes since commit 8bea8672edfca7ec5f661cafb218f1205863b343:
Stephen Rothwell (1):
mfd: compile fix for twl4030 renaming

are available in the git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap-2.6.git omap-fixes-for-linus

Balaji T K (1):
mfd: twl: fix twl4030 rename for remaining driver, board files

Mika Westerberg (1):
OMAP3: serial - fix bug introduced in

Olof Johansson (1):
omap3: Allow EHCI to be built on OMAP3

Thomas Weber (1):
USB ehci: replace mach header with plat

arch/arm/mach-omap2/Kconfig | 1 +
arch/arm/mach-omap2/board-cm-t35.c | 2 +-
arch/arm/mach-omap2/board-igep0020.c | 2 +-
arch/arm/mach-omap2/board-omap3evm.c | 2 +-
arch/arm/mach-omap2/board-omap3touchbook.c | 2 +-
arch/arm/mach-omap2/board-rx51-peripherals.c | 2 +-
arch/arm/mach-omap2/board-zoom-peripherals.c | 2 +-
arch/arm/mach-omap2/serial.c | 7 ++++---
drivers/usb/host/ehci-omap.c | 2 +-
drivers/video/omap/lcd_ldp.c | 4 ++--
drivers/video/omap/lcd_omap2evm.c | 10 +++++-----
drivers/video/omap/lcd_omap3beagle.c | 2 +-
drivers/video/omap/lcd_omap3evm.c | 10 +++++-----
drivers/video/omap/lcd_overo.c | 2 +-
sound/soc/omap/sdp3430.c | 6 +++---
15 files changed, 29 insertions(+), 27 deletions(-)


2009-12-17 11:30:28

by Sid Boyce

[permalink] [raw]
Subject: Re: [GIT PULL] omap build fixes

On 16/12/09 22:35, Tony Lindgren wrote:
> Hi Linus,
>
> Please pull omap build fixes from:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap-2.6.git omap-fixes-for-linus
>
> In addition to the three build fixes, there's also a suspend fix
> for omap serial init.
>
> Regards,
>
> Tony
>
>
> The following changes since commit 8bea8672edfca7ec5f661cafb218f1205863b343:
> Stephen Rothwell (1):
> mfd: compile fix for twl4030 renaming
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap-2.6.git omap-fixes-for-linus
>
> Balaji T K (1):
> mfd: twl: fix twl4030 rename for remaining driver, board files
>
> Mika Westerberg (1):
> OMAP3: serial - fix bug introduced in
>
> Olof Johansson (1):
> omap3: Allow EHCI to be built on OMAP3
>
> Thomas Weber (1):
> USB ehci: replace mach header with plat
>
> arch/arm/mach-omap2/Kconfig | 1 +
> arch/arm/mach-omap2/board-cm-t35.c | 2 +-
> arch/arm/mach-omap2/board-igep0020.c | 2 +-
> arch/arm/mach-omap2/board-omap3evm.c | 2 +-
> arch/arm/mach-omap2/board-omap3touchbook.c | 2 +-
> arch/arm/mach-omap2/board-rx51-peripherals.c | 2 +-
> arch/arm/mach-omap2/board-zoom-peripherals.c | 2 +-
> arch/arm/mach-omap2/serial.c | 7 ++++---
> drivers/usb/host/ehci-omap.c | 2 +-
> drivers/video/omap/lcd_ldp.c | 4 ++--
> drivers/video/omap/lcd_omap2evm.c | 10 +++++-----
> drivers/video/omap/lcd_omap3beagle.c | 2 +-
> drivers/video/omap/lcd_omap3evm.c | 10 +++++-----
> drivers/video/omap/lcd_overo.c | 2 +-
> sound/soc/omap/sdp3430.c | 6 +++---
> 15 files changed, 29 insertions(+), 27 deletions(-)
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>

uImage built, so EHCI build problem definitely fixed, just one error
I've previously encountered when building modules.
slipstream:/home/lancelot/ftp/dec09/OMAP/omap-fixes-for-linus # ARCH=arm
make -j 4 CROSS_COMPILE=/opt/arm-2009q3/bin/arm-none-eabi- modules
scripts/kconfig/conf -s arch/arm/Kconfig
CHK include/linux/version.h
SYMLINK include/asm -> include/asm-arm
make[1]: `include/asm-arm/mach-types.h' is up to date.
CHK include/linux/utsrelease.h
CALL scripts/checksyscalls.sh
<stdin>:1523: warning: #warning syscall recvmmsg not implemented
Building modules, stage 2.
MODPOST 99 modules
ERROR: "omap_ctrl_writel" [sound/soc/omap/snd-soc-omap-mcbsp.ko] undefined!
ERROR: "omap_ctrl_readl" [sound/soc/omap/snd-soc-omap-mcbsp.ko] undefined!
make[1]: *** [__modpost] Error 1
make: *** [modules] Error 2

Regards
Sid.
--
Sid Boyce ... Hamradio License G3VBV, Licensed Private Pilot
Emeritus IBM/Amdahl Mainframes and Sun/Fujitsu Servers Tech Support
Specialist, Cricket Coach
Microsoft Windows Free Zone - Linux used for all Computing Tasks

2009-12-17 17:26:20

by Tony Lindgren

[permalink] [raw]
Subject: Re: [GIT PULL] omap build fixes

* Sid Boyce <[email protected]> [091217 03:29]:

<snip>

> uImage built, so EHCI build problem definitely fixed, just one error
> I've previously encountered when building modules.
> slipstream:/home/lancelot/ftp/dec09/OMAP/omap-fixes-for-linus # ARCH=arm
> make -j 4 CROSS_COMPILE=/opt/arm-2009q3/bin/arm-none-eabi- modules
> scripts/kconfig/conf -s arch/arm/Kconfig
> CHK include/linux/version.h
> SYMLINK include/asm -> include/asm-arm
> make[1]: `include/asm-arm/mach-types.h' is up to date.
> CHK include/linux/utsrelease.h
> CALL scripts/checksyscalls.sh
> <stdin>:1523: warning: #warning syscall recvmmsg not implemented
> Building modules, stage 2.
> MODPOST 99 modules
> ERROR: "omap_ctrl_writel" [sound/soc/omap/snd-soc-omap-mcbsp.ko] undefined!
> ERROR: "omap_ctrl_readl" [sound/soc/omap/snd-soc-omap-mcbsp.ko] undefined!
> make[1]: *** [__modpost] Error 1
> make: *** [modules] Error 2

Hmm. I'm not seeing this in any of the defconfigs, so I guess this
happens with ASoC complied as a module.

But instead of exporting omap_ctrl_read/write, we need to get rid of
omap_ctrl_read/write stuff in the drivers.

It seems that omap_mcbsp_dai_set_clks_src() should be implemented in
the clock framework instead.

Regards,

Tony

2009-12-18 04:15:18

by Sid Boyce

[permalink] [raw]
Subject: Re: [GIT PULL] omap build fixes

On 17/12/09 17:26, Tony Lindgren wrote:
> * Sid Boyce <[email protected]> [091217 03:29]:
>
> <snip>
>
>> uImage built, so EHCI build problem definitely fixed, just one error
>> I've previously encountered when building modules.
>> slipstream:/home/lancelot/ftp/dec09/OMAP/omap-fixes-for-linus # ARCH=arm
>> make -j 4 CROSS_COMPILE=/opt/arm-2009q3/bin/arm-none-eabi- modules
>> scripts/kconfig/conf -s arch/arm/Kconfig
>> CHK include/linux/version.h
>> SYMLINK include/asm -> include/asm-arm
>> make[1]: `include/asm-arm/mach-types.h' is up to date.
>> CHK include/linux/utsrelease.h
>> CALL scripts/checksyscalls.sh
>> <stdin>:1523: warning: #warning syscall recvmmsg not implemented
>> Building modules, stage 2.
>> MODPOST 99 modules
>> ERROR: "omap_ctrl_writel" [sound/soc/omap/snd-soc-omap-mcbsp.ko] undefined!
>> ERROR: "omap_ctrl_readl" [sound/soc/omap/snd-soc-omap-mcbsp.ko] undefined!
>> make[1]: *** [__modpost] Error 1
>> make: *** [modules] Error 2
>
> Hmm. I'm not seeing this in any of the defconfigs, so I guess this
> happens with ASoC complied as a module.
>
> But instead of exporting omap_ctrl_read/write, we need to get rid of
> omap_ctrl_read/write stuff in the drivers.
>
> It seems that omap_mcbsp_dai_set_clks_src() should be implemented in
> the clock framework instead.
>
> Regards,
>
> Tony
>
>

Confirmed it works when compiled in.
Regards
Sid.

--
Sid Boyce ... Hamradio License G3VBV, Licensed Private Pilot
Emeritus IBM/Amdahl Mainframes and Sun/Fujitsu Servers Tech Support
Specialist, Cricket Coach
Microsoft Windows Free Zone - Linux used for all Computing Tasks