move the ACL validation check in to fs/posix_acl.c.
Including nullpointer check and PTR_ERR check.
---
Signed-off-by: Liuwenyi <[email protected]>
Cc: Alex Elder <[email protected]>
Cc: [email protected]
Cc :Christoph Hellwig <[email protected]>
Cc: Al Viro <[email protected]>
Cc: Eric Sandeen <[email protected]>
Cc: Joel Becker <[email protected]>
Cc: [email protected]
Cc: [email protected]
---
diff --git a/fs/xfs/linux-2.6/xfs_acl.c b/fs/xfs/linux-2.6/xfs_acl.c
index 2512125..3de2533 100644
--- a/fs/xfs/linux-2.6/xfs_acl.c
+++ b/fs/xfs/linux-2.6/xfs_acl.c
@@ -392,17 +392,6 @@ xfs_xattr_acl_set(struct dentry *dentry, const char
*name,
goto set_acl;
acl = posix_acl_from_xattr(value, size);
- if (!acl) {
- /*
- * acl_set_file(3) may request that we set default ACLs with
- * zero length -- defend (gracefully) against that here.
- */
- goto out;
- }
- if (IS_ERR(acl)) {
- error = PTR_ERR(acl);
- goto out;
- }
error = posix_acl_valid(acl);
if (error)
--
Best Regards,
Liuwenyi