2009-12-22 08:27:15

by Peter Huewe

[permalink] [raw]
Subject: [PATCH 1/6] uwb/i1480: add __init/__exit macros

From: Peter Huewe <[email protected]>

Trivial patch which adds the __init/__exit macros to the module_init/
module_exit functions of

uwb/i1480/i1480-est.c

@Jiri: As there is no maintainer, it seems it is up to you to decide :)

Patch against linux-next-tree, 22. Dez 08:38:18 CET 2009
but also present in linus tree.

Signed-off-by: Peter Huewe <[email protected]>
---
drivers/uwb/i1480/i1480-est.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/uwb/i1480/i1480-est.c b/drivers/uwb/i1480/i1480-est.c
index 7bf8c6f..f2eb4d8 100644
--- a/drivers/uwb/i1480/i1480-est.c
+++ b/drivers/uwb/i1480/i1480-est.c
@@ -54,7 +54,7 @@ static struct uwb_est_entry i1480_est_fd01[] = {
.size = sizeof(struct i1480_rceb) + 2 },
};

-static int i1480_est_init(void)
+static int __init i1480_est_init(void)
{
int result = uwb_est_register(i1480_CET_VS1, 0x00, 0x8086, 0x0c3b,
i1480_est_fd00,
@@ -73,7 +73,7 @@ static int i1480_est_init(void)
}
module_init(i1480_est_init);

-static void i1480_est_exit(void)
+static void __exit i1480_est_exit(void)
{
uwb_est_unregister(i1480_CET_VS1, 0x00, 0x8086, 0x0c3b,
i1480_est_fd00, ARRAY_SIZE(i1480_est_fd00));
--
1.6.4.4


2009-12-22 08:27:26

by Peter Huewe

[permalink] [raw]
Subject: [PATCH 2/6] isdn/hardware: add __init/__exit macros to isdn/hardware/mISDN/mISDNisar.c

From: Peter Huewe <[email protected]>

Trivial patch which adds the __init/__exit macros to the module_init/
module_exit functions of

drivers/isdn/hardware/mISDN/mISDNisar.c

Please have a look at the small patch and either pull it through
your tree, or please ack' it so Jiri can pull it through the trivial
tree.

Patch against linux-next-tree, 22. Dez 08:38:18 CET 2009
but also present in linus tree.

Signed-off-by: Peter Huewe <[email protected]>
---
drivers/isdn/hardware/mISDN/mISDNisar.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/isdn/hardware/mISDN/mISDNisar.c b/drivers/isdn/hardware/mISDN/mISDNisar.c
index 09095c7..f0bc6fa 100644
--- a/drivers/isdn/hardware/mISDN/mISDNisar.c
+++ b/drivers/isdn/hardware/mISDN/mISDNisar.c
@@ -1712,13 +1712,13 @@ mISDNisar_init(struct isar_hw *isar, void *hw)
}
EXPORT_SYMBOL(mISDNisar_init);

-static int isar_mod_init(void)
+static int __init isar_mod_init(void)
{
pr_notice("mISDN: ISAR driver Rev. %s\n", ISAR_REV);
return 0;
}

-static void isar_mod_cleanup(void)
+static void __exit isar_mod_cleanup(void)
{
pr_notice("mISDN: ISAR module unloaded\n");
}
--
1.6.4.4

2009-12-22 08:52:15

by Marcel Holtmann

[permalink] [raw]
Subject: Re: [PATCH 1/6] uwb/i1480: add __init/__exit macros

Hi Peter,

> Trivial patch which adds the __init/__exit macros to the module_init/
> module_exit functions of
>
> uwb/i1480/i1480-est.c
>
> @Jiri: As there is no maintainer, it seems it is up to you to decide :)

actually David Vrabel is taking care of the UWB subsystem and everything
related to it.

Regards

Marcel

2009-12-22 08:57:27

by Peter Huewe

[permalink] [raw]
Subject: Re: [PATCH 1/6] uwb/i1480: add __init/__exit macros

Am Dienstag 22 Dezember 2009 09:51:44 schrieb Marcel Holtmann:
> Hi Peter,
>
> > Trivial patch which adds the __init/__exit macros to the module_init/
> > module_exit functions of
> >
> > uwb/i1480/i1480-est.c
> >
> > @Jiri: As there is no maintainer, it seems it is up to you to decide :)
>
> actually David Vrabel is taking care of the UWB subsystem and everything
> related to it.
>
> Regards
>
> Marcel
>

Hmm, okay - thanks for the hint.

Unfortunately get-maintainers.pl did not come up with any one.

Thanks,
Peter

2009-12-22 09:08:27

by Peter Huewe

[permalink] [raw]
Subject: Re: [PATCH 1/6] uwb/i1480: add __init/__exit macros

Am Dienstag 22 Dezember 2009 09:57:25 schrieb Peter Hüwe:
> Am Dienstag 22 Dezember 2009 09:51:44 schrieb Marcel Holtmann:
> > Hi Peter,
> >
> > > Trivial patch which adds the __init/__exit macros to the module_init/
> > > module_exit functions of
> > >
> > > uwb/i1480/i1480-est.c
> > >
> > > @Jiri: As there is no maintainer, it seems it is up to you to decide :)
> >
> > actually David Vrabel is taking care of the UWB subsystem and everything
> > related to it.
> >
> > Regards
> >
> > Marcel
>
> Hmm, okay - thanks for the hint.
>
> Unfortunately get-maintainers.pl did not come up with any one.
>
> Thanks,
> Peter

Created a patch for MAINTAINERS
"[PATCH] MAINTAINERS: Fix entry for uwb to include subdirectories"


Thanks,
Peter

2009-12-22 12:21:20

by David Vrabel

[permalink] [raw]
Subject: Re: [PATCH 1/6] uwb/i1480: add __init/__exit macros

[email protected] wrote:
> From: Peter Huewe <[email protected]>
>
> Trivial patch which adds the __init/__exit macros to the module_init/
> module_exit functions of

Acked-by: David Vrabel <[email protected]>

Jiri, please merge this via the trivial tree, thanks.

David
--
David Vrabel, Senior Software Engineer, Drivers
CSR, Churchill House, Cambridge Business Park, Tel: +44 (0)1223 692562
Cowley Road, Cambridge, CB4 0WZ http://www.csr.com/


Member of the CSR plc group of companies. CSR plc registered in England and Wales, registered number 4187346, registered office Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, United Kingdom

2009-12-22 13:13:12

by Jiri Kosina

[permalink] [raw]
Subject: Re: [PATCH 1/6] uwb/i1480: add __init/__exit macros

On Tue, 22 Dec 2009, David Vrabel wrote:

> > From: Peter Huewe <[email protected]>
> >
> > Trivial patch which adds the __init/__exit macros to the module_init/
> > module_exit functions of
>
> Acked-by: David Vrabel <[email protected]>

Applied, thanks.

--
Jiri Kosina
SUSE Labs, Novell Inc.

2010-01-05 10:22:58

by Jiri Kosina

[permalink] [raw]
Subject: Re: [PATCH 2/6] isdn/hardware: add __init/__exit macros to isdn/hardware/mISDN/mISDNisar.c

On Tue, 22 Dec 2009, [email protected] wrote:

> From: Peter Huewe <[email protected]>
>
> Trivial patch which adds the __init/__exit macros to the module_init/
> module_exit functions of
>
> drivers/isdn/hardware/mISDN/mISDNisar.c

The patch doesn't seem to be present in linux-next as of today. I have
applied it to my queue.

Thanks,

--
Jiri Kosina
SUSE Labs, Novell Inc.