2010-01-14 20:27:44

by Roel Kluin

Subject: [PATCH] [NET]: da.s_net not copied but assigned to itself in aarp_rcv()

da.s_net was not copied but assigned to itself.

Signed-off-by: Roel Kluin <[email protected]>
---
diff --git a/net/appletalk/aarp.c b/net/appletalk/aarp.c
index 9d4adfd..f2b3b56 100644
--- a/net/appletalk/aarp.c
+++ b/net/appletalk/aarp.c
@@ -819,7 +819,7 @@ static int aarp_rcv(struct sk_buff *skb, struct net_device *dev,
ma = &ifa->address;
else { /* We need to make a copy of the entry. */
da.s_node = sa.s_node;
- da.s_net = da.s_net;
+ da.s_net = sa.s_net;
ma = &da;
}

2010-01-14 21:00:23

by Arnaldo Carvalho de Melo

Subject: Re: [PATCH] [NET]: da.s_net not copied but assigned to itself in aarp_rcv()

Em Thu, Jan 14, 2010 at 09:32:11PM +0100, Roel Kluin escreveu:
> da.s_net was not copied but assigned to itself.
>
> Signed-off-by: Roel Kluin <[email protected]>

Looks right, must be there for ages...

Acked-by: Arnaldo Carvalho de Melo <[email protected]>

> ---
> diff --git a/net/appletalk/aarp.c b/net/appletalk/aarp.c
> index 9d4adfd..f2b3b56 100644
> --- a/net/appletalk/aarp.c
> +++ b/net/appletalk/aarp.c
> @@ -819,7 +819,7 @@ static int aarp_rcv(struct sk_buff *skb, struct net_device *dev,
> ma = &ifa->address;
> else { /* We need to make a copy of the entry. */
> da.s_node = sa.s_node;
> - da.s_net = da.s_net;
> + da.s_net = sa.s_net;
> ma = &da;
> }
>

2010-01-15 09:49:38

by David Miller

Subject: Re: [PATCH] [NET]: da.s_net not copied but assigned to itself in aarp_rcv()

From: Arnaldo Carvalho de Melo <[email protected]>
Date: Thu, 14 Jan 2010 19:00:01 -0200

> Em Thu, Jan 14, 2010 at 09:32:11PM +0100, Roel Kluin escreveu:
>> da.s_net was not copied but assigned to itself.
>>
>> Signed-off-by: Roel Kluin <[email protected]>
>
> Looks right, must be there for ages...
>
> Acked-by: Arnaldo Carvalho de Melo <[email protected]>

Applied, please always CC: on networking patches.

Thanks.