2010-01-15 14:06:57

by Roel Kluin

Subject: [PATCH] drm/radeon/kms: crtc_ omitted in display assignments in radeon_atom_mode_fixup()?

The crtc_ prefix was omitted in h/vdisplay assignments

Signed-off-by: Roel Kluin <[email protected]>
---
Not sure, but maybe the change below is needed? please ack/nack.

diff --git a/drivers/gpu/drm/radeon/radeon_encoders.c b/drivers/gpu/drm/radeon/radeon_encoders.c
index 82eb551..a9dc073 100644
--- a/drivers/gpu/drm/radeon/radeon_encoders.c
+++ b/drivers/gpu/drm/radeon/radeon_encoders.c
@@ -233,8 +233,8 @@ static bool radeon_atom_mode_fixup(struct drm_encoder *encoder,
if (!ASIC_IS_AVIVO(rdev)) {
adjusted_mode->hdisplay = mode->hdisplay;
adjusted_mode->vdisplay = mode->vdisplay;
- adjusted_mode->crtc_hdisplay = mode->hdisplay;
- adjusted_mode->crtc_vdisplay = mode->vdisplay;
+ adjusted_mode->crtc_hdisplay = mode->crtc_hdisplay;
+ adjusted_mode->crtc_vdisplay = mode->crtc_vdisplay;
}
adjusted_mode->base.id = mode_id;
}

2010-01-15 14:27:16

by Alex Deucher

Subject: Re: [PATCH] drm/radeon/kms: crtc_ omitted in display assignments in radeon_atom_mode_fixup()?

On Fri, Jan 15, 2010 at 9:11 AM, Roel Kluin <[email protected]> wrote:
> The crtc_ prefix was omitted in h/vdisplay assignments
>
> Signed-off-by: Roel Kluin <[email protected]>
> ---
> Not sure, but maybe the change below is needed? please ack/nack.

NAK. the code is correct as is.

>
> diff --git a/drivers/gpu/drm/radeon/radeon_encoders.c b/drivers/gpu/drm/radeon/radeon_encoders.c
> index 82eb551..a9dc073 100644
> --- a/drivers/gpu/drm/radeon/radeon_encoders.c
> +++ b/drivers/gpu/drm/radeon/radeon_encoders.c
> @@ -233,8 +233,8 @@ static bool radeon_atom_mode_fixup(struct drm_encoder *encoder,
> ? ? ? ? ? ? ? ?if (!ASIC_IS_AVIVO(rdev)) {
> ? ? ? ? ? ? ? ? ? ? ? ?adjusted_mode->hdisplay = mode->hdisplay;
> ? ? ? ? ? ? ? ? ? ? ? ?adjusted_mode->vdisplay = mode->vdisplay;
> - ? ? ? ? ? ? ? ? ? ? ? adjusted_mode->crtc_hdisplay = mode->hdisplay;
> - ? ? ? ? ? ? ? ? ? ? ? adjusted_mode->crtc_vdisplay = mode->vdisplay;
> + ? ? ? ? ? ? ? ? ? ? ? adjusted_mode->crtc_hdisplay = mode->crtc_hdisplay;
> + ? ? ? ? ? ? ? ? ? ? ? adjusted_mode->crtc_vdisplay = mode->crtc_vdisplay;
> ? ? ? ? ? ? ? ?}
> ? ? ? ? ? ? ? ?adjusted_mode->base.id = mode_id;
> ? ? ? ?}
>
> ------------------------------------------------------------------------------
> Throughout its 18-year history, RSA Conference consistently attracts the
> world's best and brightest in the field, creating opportunities for Conference
> attendees to learn about information security's most important issues through
> interactions with peers, luminaries and emerging and established companies.
> http://p.sf.net/sfu/rsaconf-dev2dev
> --
> _______________________________________________
> Dri-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/dri-devel
>