2010-01-13 21:41:27

by René Bolldorf

Subject: [PATCH][CORRECTED] section mismatch: pcibios_scan_specific_bus()

Hi all,
pcibios_scan_specific_bus() is only invoked from
__devinit pcibios_fixup_peer_bridges(void).

Mark it as __devinit.
Sry for the first mail, I hadn't sleep enough...

diff --git a/arch/x86/pci/legacy.c b/arch/x86/pci/legacy.c
--- a/arch/x86/pci/legacy.c
+++ b/arch/x86/pci/legacy.c
@@ -39,7 +39,7 @@ static int __init pci_legacy_init(void)
return 0;
}

-void pcibios_scan_specific_bus(int busn)
+void __devinit pcibios_scan_specific_bus(int busn)
{
int devfn;
long node;

2010-01-15 23:40:23

by Jesse Barnes

Subject: Re: [PATCH][CORRECTED] section mismatch: pcibios_scan_specific_bus()

On Wed, 13 Jan 2010 22:41:52 +0100
René Bolldorf <[email protected]> wrote:

> Hi all,
> pcibios_scan_specific_bus() is only invoked from
> __devinit pcibios_fixup_peer_bridges(void).
>
> Mark it as __devinit.
> Sry for the first mail, I hadn't sleep enough...
>
> diff --git a/arch/x86/pci/legacy.c b/arch/x86/pci/legacy.c
> --- a/arch/x86/pci/legacy.c
> +++ b/arch/x86/pci/legacy.c
> @@ -39,7 +39,7 @@ static int __init pci_legacy_init(void)
> return 0;
> }
>
> -void pcibios_scan_specific_bus(int busn)
> +void __devinit pcibios_scan_specific_bus(int busn)
> {
> int devfn;
> long node;

Doesn't apply to my for-linus branch, also missing a Signed-off-by. I
guess you need more sleep. :) Care to refresh if it's still necessary?

Thanks,
--
Jesse Barnes, Intel Open Source Technology Center

2010-01-16 15:13:11

by René Bolldorf

Subject: Re: [PATCH][CORRECTED] section mismatch: pcibios_scan_specific_bus()

On 01/16/10 00:40, Jesse Barnes wrote:
> On Wed, 13 Jan 2010 22:41:52 +0100
> René Bolldorf<[email protected]> wrote:
>
>> Hi all,
>> pcibios_scan_specific_bus() is only invoked from
>> __devinit pcibios_fixup_peer_bridges(void).
>>
>> Mark it as __devinit.
>> Sry for the first mail, I hadn't sleep enough...
>>
>> diff --git a/arch/x86/pci/legacy.c b/arch/x86/pci/legacy.c
>> --- a/arch/x86/pci/legacy.c
>> +++ b/arch/x86/pci/legacy.c
>> @@ -39,7 +39,7 @@ static int __init pci_legacy_init(void)
>> return 0;
>> }
>>
>> -void pcibios_scan_specific_bus(int busn)
>> +void __devinit pcibios_scan_specific_bus(int busn)
>> {
>> int devfn;
>> long node;
>
> Doesn't apply to my for-linus branch, also missing a Signed-off-by. I
> guess you need more sleep. :) Care to refresh if it's still necessary?
>
> Thanks,

I pulled today
git://git.kernel.org/pub/scm/linux/kernel/git/jbarnes/pci-2.6
linux-next. pci legacy was deleted.
Now patch can be ignored.