2010-01-17 19:20:53

by Roel Kluin

Subject: [PATCH] msm_sdcc.c: missing brackets in msmsdcc_resume()

Since the curly brackets were missing the test and enable_irq(),
if true, occurred twice.

Signed-off-by: Roel Kluin <[email protected]>
---
drivers/mmc/host/msm_sdcc.c | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/drivers/mmc/host/msm_sdcc.c b/drivers/mmc/host/msm_sdcc.c
index b31946e..4c068e5 100644
--- a/drivers/mmc/host/msm_sdcc.c
+++ b/drivers/mmc/host/msm_sdcc.c
@@ -1250,9 +1250,7 @@ msmsdcc_resume(struct platform_device *dev)

if (mmc->card && mmc->card->type != MMC_TYPE_SDIO)
mmc_resume_host(mmc);
- if (host->stat_irq)
- enable_irq(host->stat_irq);
- else if (host->stat_irq)
+ if (host->stat_irq)
enable_irq(host->stat_irq);
}
return 0;

2010-01-20 20:32:59

by Daniel Walker

Subject: Re: [PATCH] msm_sdcc.c: missing brackets in msmsdcc_resume()

On Sun, 2010-01-17 at 20:25 +0100, Roel Kluin wrote:
> Since the curly brackets were missing the test and enable_irq(),
> if true, occurred twice.
>
> Signed-off-by: Roel Kluin <[email protected]>

Thanks .. I'll queue it for 2.6.34 ..

Daniel