2010-01-19 19:54:57

by Roel Kluin

[permalink] [raw]
Subject: [PATCH] thinkpad-acpi: wrong thermal attribute_group removed in thermal_exit()

sysfs_remove_group() removed the wrong attribute_group for
thermal_read_mode TPEC_8, ACPI_TMP07 and ACPI_UPDT

Signed-off-by: Roel Kluin <[email protected]>
---
Was this maybe intended? otherwise in case TPACPI_THERMAL_TPEC_16:
the same code is executed. Please review.

diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
index e67e4fe..eb603f1 100644
--- a/drivers/platform/x86/thinkpad_acpi.c
+++ b/drivers/platform/x86/thinkpad_acpi.c
@@ -5771,7 +5771,7 @@ static void thermal_exit(void)
case TPACPI_THERMAL_ACPI_TMP07:
case TPACPI_THERMAL_ACPI_UPDT:
sysfs_remove_group(&tpacpi_sensors_pdev->dev.kobj,
- &thermal_temp_input16_group);
+ &thermal_temp_input8_group);
break;
case TPACPI_THERMAL_NONE:
default:


Subject: Re: [ibm-acpi-devel] [PATCH] thinkpad-acpi: wrong thermal attribute_group removed in thermal_exit()

On Tue, 19 Jan 2010, Roel Kluin wrote:
> sysfs_remove_group() removed the wrong attribute_group for
> thermal_read_mode TPEC_8, ACPI_TMP07 and ACPI_UPDT
>
> Signed-off-by: Roel Kluin <[email protected]>

Acked-by: Henrique de Moraes Holschuh <[email protected]>

I will queue it.

--
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh