2010-01-19 21:45:30

by Roel Kluin

Subject: [PATCH] [NETLINK]: With opcode INET_DIAG_BC_S_LE dport was compared in inet_diag_bc_run()

The s-port should be compared.

Signed-off-by: Roel Kluin <[email protected]>
---
I presume?

diff --git a/net/ipv4/inet_diag.c b/net/ipv4/inet_diag.c
index bdb78dd..1aaa811 100644
--- a/net/ipv4/inet_diag.c
+++ b/net/ipv4/inet_diag.c
@@ -368,7 +368,7 @@ static int inet_diag_bc_run(const void *bc, int len,
yes = entry->sport >= op[1].no;
break;
case INET_DIAG_BC_S_LE:
- yes = entry->dport <= op[1].no;
+ yes = entry->sport <= op[1].no;
break;
case INET_DIAG_BC_D_GE:
yes = entry->dport >= op[1].no;

2010-01-19 22:12:27

by David Miller

Subject: Re: [PATCH] [NETLINK]: With opcode INET_DIAG_BC_S_LE dport was compared in inet_diag_bc_run()

From: Roel Kluin <[email protected]>
Date: Tue, 19 Jan 2010 22:50:21 +0100

> The s-port should be compared.
>
> Signed-off-by: Roel Kluin <[email protected]>
> ---
> I presume?

Yep, looks good.

Excellent catch, applied, thanks!