2010-01-20 00:42:35

by Roel Kluin

Subject: [PATCH] cx23885: Wrong command printed in cmd_to_str()

The wrong command was printed for case CX2341X_ENC_SET_DNR_FILTER_MODE,
and a typo in case CX2341X_ENC_SET_PCR_ID.

Signed-off-by: Roel Kluin <[email protected]>
---
Or is this intended?

diff --git a/drivers/media/video/cx23885/cx23885-417.c b/drivers/media/video/cx23885/cx23885-417.c
index 88c0d24..2ab97ad 100644
--- a/drivers/media/video/cx23885/cx23885-417.c
+++ b/drivers/media/video/cx23885/cx23885-417.c
@@ -681,7 +681,7 @@ static char *cmd_to_str(int cmd)
case CX2341X_ENC_SET_VIDEO_ID:
return "SET_VIDEO_ID";
case CX2341X_ENC_SET_PCR_ID:
- return "SET_PCR_PID";
+ return "SET_PCR_ID";
case CX2341X_ENC_SET_FRAME_RATE:
return "SET_FRAME_RATE";
case CX2341X_ENC_SET_FRAME_SIZE:
@@ -693,7 +693,7 @@ static char *cmd_to_str(int cmd)
case CX2341X_ENC_SET_ASPECT_RATIO:
return "SET_ASPECT_RATIO";
case CX2341X_ENC_SET_DNR_FILTER_MODE:
- return "SET_DNR_FILTER_PROPS";
+ return "SET_DNR_FILTER_MODE";
case CX2341X_ENC_SET_DNR_FILTER_PROPS:
return "SET_DNR_FILTER_PROPS";
case CX2341X_ENC_SET_CORING_LEVELS:

2010-01-20 13:00:21

by Steven Toth

Subject: Re: [PATCH] cx23885: Wrong command printed in cmd_to_str()

Thanks Roel.

Acked-By: Steven Toth <[email protected]>

- Steve

--
Steven Toth - Kernel Labs
http://www.kernellabs.com

On Tue, Jan 19, 2010 at 7:47 PM, Roel Kluin <[email protected]> wrote:
> The wrong command was printed for case CX2341X_ENC_SET_DNR_FILTER_MODE,
> and a typo in case CX2341X_ENC_SET_PCR_ID.
>
> Signed-off-by: Roel Kluin <[email protected]>
> ---
> Or is this intended?
>
> diff --git a/drivers/media/video/cx23885/cx23885-417.c b/drivers/media/video/cx23885/cx23885-417.c
> index 88c0d24..2ab97ad 100644
> --- a/drivers/media/video/cx23885/cx23885-417.c
> +++ b/drivers/media/video/cx23885/cx23885-417.c
> @@ -681,7 +681,7 @@ static char *cmd_to_str(int cmd)
> ? ? ? ?case CX2341X_ENC_SET_VIDEO_ID:
> ? ? ? ? ? ? ? ?return ?"SET_VIDEO_ID";
> ? ? ? ?case CX2341X_ENC_SET_PCR_ID:
> - ? ? ? ? ? ? ? return ?"SET_PCR_PID";
> + ? ? ? ? ? ? ? return ?"SET_PCR_ID";
> ? ? ? ?case CX2341X_ENC_SET_FRAME_RATE:
> ? ? ? ? ? ? ? ?return ?"SET_FRAME_RATE";
> ? ? ? ?case CX2341X_ENC_SET_FRAME_SIZE:
> @@ -693,7 +693,7 @@ static char *cmd_to_str(int cmd)
> ? ? ? ?case CX2341X_ENC_SET_ASPECT_RATIO:
> ? ? ? ? ? ? ? ?return ?"SET_ASPECT_RATIO";
> ? ? ? ?case CX2341X_ENC_SET_DNR_FILTER_MODE:
> - ? ? ? ? ? ? ? return ?"SET_DNR_FILTER_PROPS";
> + ? ? ? ? ? ? ? return ?"SET_DNR_FILTER_MODE";
> ? ? ? ?case CX2341X_ENC_SET_DNR_FILTER_PROPS:
> ? ? ? ? ? ? ? ?return ?"SET_DNR_FILTER_PROPS";
> ? ? ? ?case CX2341X_ENC_SET_CORING_LEVELS:
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to [email protected]
> More majordomo info at ?http://vger.kernel.org/majordomo-info.html
>



--
Steven Toth - Kernel Labs
http://www.kernellabs.com