2010-04-07 17:12:11

by Chad Talbott

[permalink] [raw]
Subject: Re: [PATCH 1/2 V3] io-controller: Add a new interface "weight_device" for IO-Controller

On Wed, Mar 24, 2010 at 11:28 PM, Gui Jianfeng
<[email protected]> wrote:
> Vivek Goyal wrote:
>> On Fri, Mar 05, 2010 at 10:25:58AM +0800, Gui Jianfeng wrote:
>>> V2->V3 changes:
>>> - Move policy_*_node() functions up to get rid of forward declarations
>>> - rename related functions by adding prefix "blkio_"
>>>
>>
>> Thanks for the changes Gui. Looks good to me.
>>
>> Acked-by: Vivek Goyal <[email protected]>
>
> Hi Jens,
>
> This patchset seems to get lost. Just for reminding. Any comments?

Hi Jens,

Just want to add a quick note that we're excited about this
functionality and are hoping to see it go in.

Chad


2010-04-07 17:28:46

by Vivek Goyal

[permalink] [raw]
Subject: Re: [PATCH 1/2 V3] io-controller: Add a new interface "weight_device" for IO-Controller

On Wed, Apr 07, 2010 at 10:12:03AM -0700, Chad Talbott wrote:
> On Wed, Mar 24, 2010 at 11:28 PM, Gui Jianfeng
> <[email protected]> wrote:
> > Vivek Goyal wrote:
> >> On Fri, Mar 05, 2010 at 10:25:58AM +0800, Gui Jianfeng wrote:
> >>> V2->V3 changes:
> >>> - Move policy_*_node() functions up to get rid of forward declarations
> >>> - rename related functions by adding prefix "blkio_"
> >>>
> >>
> >> Thanks for the changes Gui. Looks good to me.
> >>
> >> Acked-by: Vivek Goyal <[email protected]>
> >
> > Hi Jens,
> >
> > This patchset seems to get lost. Just for reminding. Any comments?
>
> Hi Jens,
>
> Just want to add a quick note that we're excited about this
> functionality and are hoping to see it go in.
>

I guess this patchset is now going to conflict with Divyesh's changes.

Gui, once blkio stat patches (cleaned up ones) are committed may be you
can rebase your changes on top of that. It will become easier for Jens.
(Until and unless he has some objections to this patchset).

Thanks
Vivek

2010-04-08 00:11:40

by Gui, Jianfeng/归 剑峰

[permalink] [raw]
Subject: Re: [PATCH 1/2 V3] io-controller: Add a new interface "weight_device" for IO-Controller

Vivek Goyal wrote:
> On Wed, Apr 07, 2010 at 10:12:03AM -0700, Chad Talbott wrote:
>> On Wed, Mar 24, 2010 at 11:28 PM, Gui Jianfeng
>> <[email protected]> wrote:
>>> Vivek Goyal wrote:
>>>> On Fri, Mar 05, 2010 at 10:25:58AM +0800, Gui Jianfeng wrote:
>>>>> V2->V3 changes:
>>>>> - Move policy_*_node() functions up to get rid of forward declarations
>>>>> - rename related functions by adding prefix "blkio_"
>>>>>
>>>> Thanks for the changes Gui. Looks good to me.
>>>>
>>>> Acked-by: Vivek Goyal <[email protected]>
>>> Hi Jens,
>>>
>>> This patchset seems to get lost. Just for reminding. Any comments?
>> Hi Jens,
>>
>> Just want to add a quick note that we're excited about this
>> functionality and are hoping to see it go in.
>>
>
> I guess this patchset is now going to conflict with Divyesh's changes.
>
> Gui, once blkio stat patches (cleaned up ones) are committed may be you
> can rebase your changes on top of that. It will become easier for Jens.
> (Until and unless he has some objections to this patchset).

Sure, will do.

Thanks,
Gui

>
> Thanks
> Vivek
>
>