2010-04-14 20:46:34

by Peter M. Petrakis

[permalink] [raw]
Subject: [PATCH] Reset ps/2 port should psmouse_probe fail before retrying

Filed a bug on this too:

https://bugzilla.kernel.org/show_bug.cgi?id=15780

This particular laptop will lose it's synaptics touch
pad on return from suspend state. Reloading the psmouse
module makes no difference. I came up with the attached
work around which simply calls psmouse_reset on the
port should the initial probe fail. This solves the problem
for me and I've tested this on several laptops.

Initially discovered on Ubuntu 2.6.31 (karmic) and the problem
continues to exist in lucid 2.6.32. I've filed a bug against
ubuntu kernel here:

https://bugs.launchpad.net/oem-priority/+bug/551234

though the Ubuntu kernel team would really like to get upstream's
input on the matter before accepting the patch. Please
let me know what you think. Thanks.

Peter



Attachments:
psmouse_reset.patch (1.15 kB)

2010-04-14 21:05:16

by Randy Dunlap

[permalink] [raw]
Subject: Re: [PATCH] Reset ps/2 port should psmouse_probe fail before retrying

On Wed, 14 Apr 2010 16:46:29 -0400 Peter M. Petrakis wrote:

> Filed a bug on this too:
>
> https://bugzilla.kernel.org/show_bug.cgi?id=15780
>
> This particular laptop will lose it's synaptics touch
> pad on return from suspend state. Reloading the psmouse
> module makes no difference. I came up with the attached
> work around which simply calls psmouse_reset on the
> port should the initial probe fail. This solves the problem
> for me and I've tested this on several laptops.
>
> Initially discovered on Ubuntu 2.6.31 (karmic) and the problem
> continues to exist in lucid 2.6.32. I've filed a bug against
> ubuntu kernel here:
>
> https://bugs.launchpad.net/oem-priority/+bug/551234
>
> though the Ubuntu kernel team would really like to get upstream's
> input on the matter before accepting the patch. Please
> let me know what you think. Thanks.

Hi,

Please send patches inline, not as attachments.
Use the full source file path in the patch.
Send the patch to [email protected] and cc: the Input
subsystem maintainer.

typo: s/reseting/resetting/


Other than those 4 things, the patch looks OK to me.
Well, we would prefer not to have the
((ret = __psmouse_probe(psmouse)) != 0)
inside the for expression if possible. I.e., make the for(...) simpler.


Please read/review Documentation/SubmittingPatches. Thanks.

---
~Randy