2010-04-16 06:39:09

by Gui, Jianfeng/归 剑峰

[permalink] [raw]
Subject: [PATCH] io-controller: including "linux/sched.h"

Include sched.h explicitly since sched_clock() is called.

Signed-off-by: Gui Jianfeng <[email protected]>
---
block/blk-cgroup.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/block/blk-cgroup.c b/block/blk-cgroup.c
index 83930f6..ed6590e 100644
--- a/block/blk-cgroup.c
+++ b/block/blk-cgroup.c
@@ -19,6 +19,7 @@
#include <linux/slab.h>
#include "blk-cgroup.h"
#include <linux/genhd.h>
+#include <linux/sched.h>

#define MAX_KEY_LEN 100

--
1.5.4.rc3


2010-04-16 06:49:43

by Jens Axboe

[permalink] [raw]
Subject: Re: [PATCH] io-controller: including "linux/sched.h"

On Fri, Apr 16 2010, Gui Jianfeng wrote:
> Include sched.h explicitly since sched_clock() is called.

Why is it using sched_clock(), btw? It would seem more appropriate to
use ktime.

--
Jens Axboe

2010-04-16 07:18:18

by Gui, Jianfeng/归 剑峰

[permalink] [raw]
Subject: Re: [PATCH] io-controller: including "linux/sched.h"

Jens Axboe wrote:
> On Fri, Apr 16 2010, Gui Jianfeng wrote:
>> Include sched.h explicitly since sched_clock() is called.
>
> Why is it using sched_clock(), btw? It would seem more appropriate to
> use ktime.

I guess the reason is it's easy to use. :)
Divyesh, right?

Gui
>